More kubeadm docs#1492
Conversation
| This process works with local VMs, physical servers and/or cloud servers. | ||
| It is simple enough that you can easily integrate its use into your own automation (Terraform, Chef, Puppet, etc). | ||
|
|
||
| The full reference for `kubeadm` is [here](/docs/admin/kubeadm/). Please refer to that for all of the command line flags and advice for automating `kubeadm` itself. |
There was a problem hiding this comment.
There are two links on this page to the reference.
If you're convinced that we need a third, it's fine for me, otherwise move or remove
There was a problem hiding this comment.
Heh -- I only see one other link. When I wrote this I wasn't completely up to date and missed that it was already there. I think the link could be more prominent but happy to remove this if you like.
There was a problem hiding this comment.
"See the full kubeadm reference for information on all kubeadm command-line flags and for advice on automating kubeadm itself."
|
I'm going on a journey to London the rest of the week, so can't review it Reassigning to @errordeveloper Also cc @kubernetes/sig-cluster-lifecycle |
|
|
||
| `kubeadm join` has one mandatory flag, the token used to secure cluster bootstrap, | ||
| and one mandatory argument, the master IP address. | ||
| `kubeadm join` has one mandatory flag, the token used to secure cluster |
There was a problem hiding this comment.
The commas make this read like a list of four things instead of a list of two things. What's the difference between a flag and an argument?
Suggest a reword: "When you use kubeadm join, you must supply the token used to secure cluster boostrap as a mandatory flag, and the master IP address as a mandatory argument."
There was a problem hiding this comment.
I just reflowed the text but happy to make changes here.
|
|
||
| ## Automating kubeadm | ||
|
|
||
| While most of the tutorials for kubeadm are linear and involve copying the token from `kubeadm init` to each node, you can parallelize this for easier automation. The only requirement is that you know the IP that master will have after it is started. |
There was a problem hiding this comment.
"Rather than copying the token you obtained from kubeadm init to each node, as in the basic kubeadm tutorials, you can parallelize the token distribution for easier automation. To implement this automation, you must know the IP address that the master will have after it is started."
| This process works with local VMs, physical servers and/or cloud servers. | ||
| It is simple enough that you can easily integrate its use into your own automation (Terraform, Chef, Puppet, etc). | ||
|
|
||
| The full reference for `kubeadm` is [here](/docs/admin/kubeadm/). Please refer to that for all of the command line flags and advice for automating `kubeadm` itself. |
There was a problem hiding this comment.
"See the full kubeadm reference for information on all kubeadm command-line flags and for advice on automating kubeadm itself."
|
PTAL |
|
Docs LGTM. Waiting on tech review. |
|
Can someone from @kubernetes/sig-cluster-lifecycle give this a review and we can get it merged? |
|
Docs LGTM. |
|
@pires -- can you say "Tech Review LGTM"? |
|
Tech Review LGTM |
|
LGTM, but I can't merge it; it needs a rebase unfortunately |
|
Rebased. PTAL |
|
Merging then based on earlier LGTMs |
* Fix kubernetes#1491 `linkerd-base` chart doesn't exist. Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com> * Update linkerd.io/content/2.12/tasks/automatically-rotating-control-plane-tls-credentials.md Co-authored-by: Alejandro Pedraza <alejandro.pedraza@gmail.com> Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com> Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com> Co-authored-by: Alejandro Pedraza <alejandro.pedraza@gmail.com>
Signed-off-by: Michael <cloudyonspring@126.com> Signed-off-by: Michael <cloudyonspring@126.com>
This change is