Skip to content

translate to fr replicaset#14908

Merged
k8s-ci-robot merged 5 commits into
kubernetes:masterfrom
portepa:fr-replicaset
Jun 24, 2019
Merged

translate to fr replicaset#14908
k8s-ci-robot merged 5 commits into
kubernetes:masterfrom
portepa:fr-replicaset

Conversation

@portepa

@portepa portepa commented Jun 15, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot

k8s-ci-robot commented Jun 15, 2019

Copy link
Copy Markdown
Contributor

Welcome @portepa!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

k8s-ci-robot commented Jun 15, 2019

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/fr Issues or PRs related to French language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from AWKIF and remyleone June 15, 2019 13:08
@remyleone remyleone self-assigned this Jun 15, 2019
@netlify

netlify Bot commented Jun 15, 2019 •
edited
Loading

Copy link
Copy Markdown

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 052c4ef

https://deploy-preview-14908--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 15, 2019
remyleone
remyleone reviewed Jun 16, 2019
View reviewed changes
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 16, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 16, 2019
sftim
sftim reviewed Jun 16, 2019
View reviewed changes

@sftim sftim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne parle pas francais couramment (je suis anglais). Malgré cela, j'espère que ces notes sonts utiles.

Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment thread content/fr/docs/concepts/workloads/controllers/replicaset.md
@remyleone

remyleone commented Jun 18, 2019

Copy link
Copy Markdown
Contributor

@portepa Est ce que tu as pu voir mes commentaires laissés dans ta PR?

@remyleone

remyleone commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@k8s-ci-robot

k8s-ci-robot commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: remyleone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 11afa09 into kubernetes:master Jun 24, 2019
joaovitor pushed a commit to joaovitor/website that referenced this pull request Jul 5, 2019
@portepa @joaovitor
translate to fr replicaset (kubernetes#14908)
3958dee 
* translate to fr replicaset

* Remove reviewers from header file

* Update replicaset.md reflecting remyleone's comments

* Update replicaset.md reflecting sftim's comments

* Update replicaset.md reflecting remyleone's (forgotten) comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone remyleone left review comments

@AWKIF AWKIF Awaiting requested review from AWKIF

+1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@remyleone remyleone

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@portepa @k8s-ci-robot @remyleone @sftim