Skip to content

zh-trans:/docs/tutorials/hello-minikube.md#14795

Merged
k8s-ci-robot merged 6 commits intokubernetes:release-1.14from
MJ-CJM:zh-trans-1.1
Jun 23, 2019
Merged

zh-trans:/docs/tutorials/hello-minikube.md#14795
k8s-ci-robot merged 6 commits intokubernetes:release-1.14from
MJ-CJM:zh-trans-1.1

Conversation

@MJ-CJM
Copy link
Copy Markdown

@MJ-CJM MJ-CJM commented Jun 9, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 9, 2019
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 9, 2019
Copy link
Copy Markdown

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2019
Copy link
Copy Markdown

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2019
@markthink
Copy link
Copy Markdown

markthink commented Jun 9, 2019

/approve cancel

需解决编译问题

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2019
@MJ-CJM
Copy link
Copy Markdown
Author

MJ-CJM commented Jun 10, 2019

/approve cancel

需解决编译问题

好的,我看看那里有问题。谢谢,小龙哥。

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2019
@MJ-CJM
Copy link
Copy Markdown
Author

MJ-CJM commented Jun 10, 2019

/approve cancel
需解决编译问题

好的,我看看那里有问题。谢谢,小龙哥。

缺少了两个用例的文件,我已经加进去了,现在应该没问题了。

* Learn more about [Deploying applications](/docs/user-guide/deploying-applications/).
* Learn more about [Service objects](/docs/concepts/services-networking/service/).
-->
* 学习更多关于 [Deployment 对象](/docs/concepts/workloads/controllers/deployment/)。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"学习更多关于 Deployment 对象"

这不是正常的中文表述方式。请考虑"进一步了解 Deployment 对象"。

Copy link
Copy Markdown
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment

@MJ-CJM
Copy link
Copy Markdown
Author

MJ-CJM commented Jun 10, 2019

See inline comment
Thank you very much for your review, I have adopted your suggestion.

@markthink
Copy link
Copy Markdown

@MJ-CJM
Copy link
Copy Markdown
Author

MJ-CJM commented Jun 21, 2019

@MJ-CJM 预览有问题:
https://deploy-preview-14795--k8s-v1-14.netlify.com/zh/docs/tutorials/hello-minikube/

已经修改完毕,非常感谢。

Copy link
Copy Markdown

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3b21a78 into kubernetes:release-1.14 Jun 23, 2019
SataQiu pushed a commit to SataQiu/website that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants