Initialize Secret in Bahasa Indonesia. by irvifa · Pull Request #14792 · kubernetes/website

irvifa · 2019-06-09T02:44:44Z

This address #13929

irvifa · 2019-06-09T02:44:54Z

/assign @girikuncoro

netlify · 2019-06-09T02:52:44Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d11e062

https://deploy-preview-14792--kubernetes-io-master-staging.netlify.com

sftim

A few suggestions. I hope these are useful; if they're not, please feel free to skip them.

sftim · 2019-06-10T10:15:39Z

content/id/docs/concepts/configuration/secret.md

+
+Sebagai contoh, untuk menghasilan sebuah Secret dari _file-file_ `./username.txt` dan `./password.txt`
+```shell
+# Create a kustomization.yaml file with SecretGenerator


Should this comment be localized into Bahasa Indonesia?

@sftim Have difficulties on the glossary_tooltip doesn't rendered properly even though I already created all needed glossaries

sftim · 2019-06-10T10:15:58Z

content/id/docs/concepts/configuration/secret.md

+Sebagai contoh, untuk membuat sebuah Secret dari literal `username=admin` dan `password=secret`,
+kamu dapat menspesifikasikan _generator_ Secret pada _file_ `kustomization.yaml` sebagai
+```shell
+# Create a kustomization.yaml file with SecretGenerator


Should this comment be localized into Bahasa Indonesia?

content/id/docs/concepts/configuration/secret.md

girikuncoro

Thanks for your great work, please address my comments! 🎉 🎉 🎉

content/id/docs/concepts/configuration/secret.md

girikuncoro · 2019-06-14T06:40:53Z

content/id/docs/concepts/configuration/secret.md

+Objek `secret` pada Kubernetes mengizinkan kamu menyimpan dan mengatur informasi yang sifatnya sensitif, seperti
+_passwords_, token OAuth, dan ssh _keys_. Menyimpan informasi yang sifatnya sensitif ini ke dalam `secret`
+cenderung lebih aman dan fleksible jika dibandingkan dengan menyimpan informasi tersebut secara apa adanya pada
+definisi {{< glossary_tooltip term_id="pod" >}} atau di dalam {{< glossary_tooltip text="container image" term_id="image" >}}.


seems like glossary_tooltip is broken, is there a way to fix this?

https://deploy-preview-14792--kubernetes-io-master-staging.netlify.com/id/docs/concepts/configuration/secret/

content/id/docs/concepts/configuration/secret.md

girikuncoro · 2019-06-14T07:20:29Z

content/id/docs/concepts/configuration/secret.md

+pada sebuah Pod:
+
+1. Buatlah sebuah Secret, atau gunakan sebuah Secret yang sudah kamu buat sebelumnya. Beberapa Pod dapat merujuk pada sebuah Secret yang sama.
+1. Modifikasi definisi Pod pada setiap kontainer dimana kamu menginginkan kontainer tersebut dapat mengonsumsi your Pod definition in each container that you wish to consume the value of a secret key to add an environment variable for each secret key you wish to consume.  The environment variable that consumes the secret key should populate the secret's name and key in `env[].valueFrom.secretKeyRef`.


missing translation

content/id/docs/concepts/configuration/secret.md

girikuncoro · 2019-06-21T06:47:19Z

content/id/docs/concepts/configuration/secret.md

+## Menggunakan Secret
+
+Secret dapat di-_mount_ sebagai _volume_ data atau dapat diekspos sebagai 
+{{< glossary_tooltip text="variabel-variabel environment" term_id="container-env-variabeles" >}}


typo:

Suggested change

{{< glossary_tooltip text="variabel-variabel environment" term_id="container-env-variabeles" >}}

{{< glossary_tooltip text="variabel-variabel environment" term_id="container-env-variables" >}}

then

add https://github.com/kubernetes/website/blob/master/content/en/docs/reference/glossary/container-env-variables.md to id/docs/references/glossary/container-env-variables.md

I think you also need to add more files to the id/docs/references/glossary

irvifa · 2019-06-24T06:41:22Z

/retest

raelga · 2019-07-13T13:32:40Z

Hi @irvifa ,

I got it working locally:

By replacing the tabs per spaces at glossary-terms partial #15408:

https://github.com/kubernetes/website/blob/master/layouts/partials/docs/glossary-terms.html

@rgarcia:~/gh/irvifa/website
$ git diff
diff --git a/layouts/partials/docs/glossary-terms.html b/layouts/partials/docs/glossary-terms.html
index fcc5171c2..b0153d49f 100644
--- a/layouts/partials/docs/glossary-terms.html
+++ b/layouts/partials/docs/glossary-terms.html
@@ -1,13 +1,13 @@
 {{ $glossaryBundle := site.GetPage "page" "docs/reference/glossary" }}
 {{- if $glossaryBundle -}}
-       {{ $pages := $glossaryBundle.Resources.ByType "page" }}
-       {{- range site.Params.language_alternatives -}}
-               {{- with (where $glossaryBundle.Translations ".Lang" . ) -}}
-               {{ $p := (index . 0) }}
-               {{ $pages = $pages | lang.Merge ($p.Resources.ByType "page") }}
-               {{ end }}
-       {{ end }}
-       {{- $.Scratch.Set "glossary_items"  $pages -}}
+  {{ $pages := $glossaryBundle.Resources.ByType "page" }}
+  {{- range site.Params.language_alternatives -}}
+    {{- with (where $glossaryBundle.Translations ".Lang" . ) -}}
+    {{ $p := (index . 0) }}
+    {{ $pages = $pages | lang.Merge ($p.Resources.ByType "page") }}
+    {{ end }}
+  {{ end }}
+  {{- $.Scratch.Set "glossary_items"  $pages -}}
 {{- else -}}
 {{- errorf "[%s] Glossary Bundle not found for language. Create at least an index.md file inside docs/reference/glossary" site.Language.Lang -}}
 {{- end -}}

Maybe @bep can share some insights on this issue.

/cc @bep

k8s-ci-robot · 2019-07-13T13:32:41Z

@raelga: GitHub didn't allow me to request PR reviews from the following users: bep.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Hi @irvifa ,

I got it working locally:

By replacing the tabs per spaces at:

https://github.com/kubernetes/website/blob/master/layouts/partials/docs/glossary-terms.html

@rgarcia:~/gh/irvifa/website
$ git diff
diff --git a/layouts/partials/docs/glossary-terms.html b/layouts/partials/docs/glossary-terms.html
index fcc5171c2..b0153d49f 100644
--- a/layouts/partials/docs/glossary-terms.html
+++ b/layouts/partials/docs/glossary-terms.html
@@ -1,13 +1,13 @@
{{ $glossaryBundle := site.GetPage "page" "docs/reference/glossary" }}
{{- if $glossaryBundle -}}
-       {{ $pages := $glossaryBundle.Resources.ByType "page" }}
-       {{- range site.Params.language_alternatives -}}
-               {{- with (where $glossaryBundle.Translations ".Lang" . ) -}}
-               {{ $p := (index . 0) }}
-               {{ $pages = $pages | lang.Merge ($p.Resources.ByType "page") }}
-               {{ end }}
-       {{ end }}
-       {{- $.Scratch.Set "glossary_items"  $pages -}}
+  {{ $pages := $glossaryBundle.Resources.ByType "page" }}
+  {{- range site.Params.language_alternatives -}}
+    {{- with (where $glossaryBundle.Translations ".Lang" . ) -}}
+    {{ $p := (index . 0) }}
+    {{ $pages = $pages | lang.Merge ($p.Resources.ByType "page") }}
+    {{ end }}
+  {{ end }}
+  {{- $.Scratch.Set "glossary_items"  $pages -}}
{{- else -}}
{{- errorf "[%s] Glossary Bundle not found for language. Create at least an index.md file inside docs/reference/glossary" site.Language.Lang -}}
{{- end -}}

Maybe @bep can share some insights on this issue.

/cc @bep

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

irvifa · 2019-07-14T10:17:02Z

@raelga Thanks a lot 👍

Using tabs in this partials seems to cause Hugo to parse the partial as a code block instead of rendering the HTML code. Solves #14792 rendering issues.

irvifa · 2019-07-14T10:47:18Z

Rebased it after #15408 and it's working like a charm..

girikuncoro · 2019-07-15T05:57:12Z

content/id/docs/concepts/configuration/secret.md

+Objek `secret` pada Kubernetes mengizinkan kamu menyimpan dan mengatur informasi yang sifatnya sensitif, seperti
+_password_, token OAuth, dan ssh _keys_. Menyimpan informasi yang sifatnya sensitif ini ke dalam `secret`
+cenderung lebih aman dan fleksible jika dibandingkan dengan menyimpan informasi tersebut secara apa adanya pada
+definisi {{< glossary_tooltip term_id="pod" >}} atau di dalam {{< glossary_tooltip text="container image" term_id="image" >}}.


Some lines are still breaking for the glossary, not sure why

any clue @raelga ?

https://deploy-preview-14792--kubernetes-io-master-staging.netlify.com/docs/concepts/configuration/secret/

Looking into it! 🔍

I already tried to use editorconfig, but still nothing happened 😞
https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig
https://www.jetbrains.com/help/idea/configuring-code-style.html

girikuncoro · 2019-07-15T05:58:46Z

content/id/docs/concepts/configuration/secret.md

+
+Untuk menggunakan Secret, sebuah Pod haruslah merujuk pada Secret tersebut.
+Sebuah Secret dapat digunakan di dalam sebuah Pod melalui dua cara:
+sebagai _file_ yang ada di dalam _volume_ {{< glossary_tooltip text="volume" term_id="volume" >}}


same with this, glossary lines are breaking

sftim · 2019-10-07T17:03:36Z

I don't speak Bahasa Indonesia
/uncc

fejta-bot · 2020-01-05T17:07:19Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

irvifa · 2020-01-05T17:40:06Z

/remove-lifecycle stale

sftim · 2020-01-14T23:51:30Z

@irvifa you're still looking for reviews on this?

irvifa · 2020-01-14T23:55:48Z

Hi, this is still not working, there’s still broken code formatting in this PR.

…

On Mon, 6 Jan 2020 at 12.07 AM fejta-bot ***@***.***> wrote: Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to sig-testing, kubernetes/test-infra and/or fejta <https://github.com/fejta>. /lifecycle stale — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14792?email_source=notifications&email_token=ABYYJZQFGNC2A6YR2TEY6RTQ4IHURA5CNFSM4HWIRGC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEID3D4Y#issuecomment-570929651>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYYJZUSYEYYCWXBBF2RNVLQ4IHURANCNFSM4HWIRGCQ> .

girikuncoro · 2020-02-07T11:43:07Z

let's triage this together and help @irvifa getting this merged
/cc @kubernetes/sig-docs-id-reviews

wahyuoi · 2020-02-07T12:47:18Z

Hi @irvifa @girikuncoro
I just tried to build from id/secret branch, and found few errors. But it solved by merging from upstream/master.

Maybe we need to update something by merging master 🤔

kbhawkey · 2020-02-13T19:53:29Z

Ping @irvifa , Just checking if you are working on this pull request?

irvifa · 2020-03-20T11:47:57Z

@kbhawkey Yes, I'm working on this

irvifa · 2020-03-20T12:13:16Z

/cc @wahyuoi

girikuncoro · 2020-03-24T11:56:08Z

@irvifa finally you made it, nicely done! thanks @wahyuoi for helping out

/lgtm
/approve

k8s-ci-robot · 2020-03-24T11:56:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/id/OWNERS~~ [girikuncoro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sftim · 2020-03-24T16:39:39Z

/hold
pending v1.18 Kubernetes release

VineethReddy02 · 2020-03-26T07:41:36Z

/hold cancel
v1.18 release is out.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 9, 2019

k8s-ci-robot assigned girikuncoro Jun 9, 2019

k8s-ci-robot requested review from girikuncoro and jimangel June 9, 2019 02:44

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 9, 2019

irvifa removed the request for review from jimangel June 9, 2019 02:45

sftim reviewed Jun 10, 2019

View reviewed changes

girikuncoro requested changes Jun 14, 2019

View reviewed changes

girikuncoro mentioned this pull request Jun 15, 2019

Tracking Indonesian Translation Progress (M1) #13929

Closed

80 tasks

girikuncoro reviewed Jun 21, 2019

View reviewed changes

irvifa force-pushed the id/secret branch from 75fb700 to d5cf415 Compare June 24, 2019 05:18

irvifa force-pushed the id/secret branch from 8baf7cb to 0c64b08 Compare June 24, 2019 07:10

girikuncoro mentioned this pull request Jul 8, 2019

Tracking Indonesian Translation Progress (M2) #15341

Closed

45 tasks

raelga mentioned this pull request Jul 13, 2019

Replace tabs by spaces in glossary-terms partials #15408

Merged

irvifa force-pushed the id/secret branch from 937601e to 6c536a1 Compare July 14, 2019 10:44

girikuncoro reviewed Jul 15, 2019

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2020

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2020

irvifa force-pushed the id/secret branch from b25f28a to a27a554 Compare March 20, 2020 11:46

irvifa force-pushed the id/secret branch from a27a554 to 471ae61 Compare March 20, 2020 11:50

k8s-ci-robot requested a review from wahyuoi March 20, 2020 12:13

Initialize Secret in Bahasa Indonesia.

d11e062

irvifa force-pushed the id/secret branch from 471ae61 to d11e062 Compare March 24, 2020 04:10

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020

sftim mentioned this pull request Mar 24, 2020

Freeze kubernetes/website to support easy 1.18 Kubernetes release #19809

Closed

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020

k8s-ci-robot merged commit 884fc46 into kubernetes:master Mar 26, 2020

fancc pushed a commit to fancc/website that referenced this pull request Apr 26, 2020

Initialize Secret in Bahasa Indonesia. (kubernetes#14792)

cd9d560

	{{< glossary_tooltip text="variabel-variabel environment" term_id="container-env-variabeles" >}}
	{{< glossary_tooltip text="variabel-variabel environment" term_id="container-env-variables" >}}

Conversation

irvifa commented Jun 9, 2019

Uh oh!

irvifa commented Jun 9, 2019

Uh oh!

netlify bot commented Jun 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

girikuncoro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

irvifa commented Jun 24, 2019

Uh oh!

raelga commented Jul 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 13, 2019

Uh oh!

irvifa commented Jul 14, 2019

Uh oh!

irvifa commented Jul 14, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sftim commented Oct 7, 2019

Uh oh!

fejta-bot commented Jan 5, 2020

Uh oh!

irvifa commented Jan 5, 2020

Uh oh!

sftim commented Jan 14, 2020

Uh oh!

irvifa commented Jan 14, 2020 via email

Uh oh!

girikuncoro commented Feb 7, 2020

Uh oh!

wahyuoi commented Feb 7, 2020

Uh oh!

kbhawkey commented Feb 13, 2020

Uh oh!

irvifa commented Mar 20, 2020

Uh oh!

irvifa commented Mar 20, 2020

Uh oh!

girikuncoro commented Mar 24, 2020

Uh oh!

netlify bot commented Jun 9, 2019 •

edited

Loading

raelga commented Jul 13, 2019 •

edited

Loading