Skip to content

zh-trans:content/zh/docs/reference/access-authn-authz/admission-contr…#14443

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.14from
cnfatal:content-zh-docs-reference-access-authn-authz-extensible-admission-controllers
May 22, 2019
Merged

zh-trans:content/zh/docs/reference/access-authn-authz/admission-contr…#14443
k8s-ci-robot merged 1 commit intokubernetes:release-1.14from
cnfatal:content-zh-docs-reference-access-authn-authz-extensible-admission-controllers

Conversation

@cnfatal
Copy link
Copy Markdown

@cnfatal cnfatal commented May 21, 2019

…ollers.md

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please delete this note before submitting the pull request.

For 1.15 Features: set Milestone to 1.15 and Base Branch to dev-1.15

For Chinese localization, base branch to release-1.14

For Korean Localization: set Base Branch to dev-1.14-ko.<latest team milestone>

Help editing and submitting pull requests:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

Help choosing which branch to use:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2019
@k8s-ci-robot k8s-ci-robot requested review from SataQiu and pigletfly May 21, 2019 15:11
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 21, 2019
SataQiu
SataQiu reviewed May 22, 2019
View reviewed changes
@SataQiu
Copy link
Copy Markdown
Member

SataQiu commented May 22, 2019

@FatalC
👍 翻译的不错，就是格式上存在一些小瑕疵。
做了一些简单的批注，还请修正下。

@cnfatal
zh-trans:content/zh/docs/reference/access-authn-authz/admission-contr…
312a594 
…ollers.md

Update content/zh/docs/reference/access-authn-authz/extensible-admission-controllers.md

Co-Authored-By: SataQiu <1527062125@qq.com>

Apply suggestions from code review

Co-Authored-By: SataQiu <1527062125@qq.com>

zh-trans:content/zh/docs/reference/access-authn-authz/admission-controllers.md
@cnfatal
Copy link
Copy Markdown
Author

cnfatal commented May 22, 2019

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 22, 2019

@FatalC: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cnfatal
Copy link
Copy Markdown
Author

cnfatal commented May 22, 2019

@SataQiu 已做修改，感谢指正

@SataQiu
Copy link
Copy Markdown
Member

SataQiu commented May 22, 2019

/lgtm
/approve
Thanks @FatalC

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3ee6603 into kubernetes:release-1.14 May 22, 2019
SataQiu pushed a commit to SataQiu/website that referenced this pull request Oct 9, 2019
@cnfatal @SataQiu
zh-trans:content/zh/docs/reference/access-authn-authz/admission-contr…
00e10be 
…ollers.md (kubernetes#14443)

Update content/zh/docs/reference/access-authn-authz/extensible-admission-controllers.md

Co-Authored-By: SataQiu <1527062125@qq.com>

Apply suggestions from code review

Co-Authored-By: SataQiu <1527062125@qq.com>

zh-trans:content/zh/docs/reference/access-authn-authz/admission-controllers.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SataQiu SataQiu SataQiu left review comments

@pigletfly pigletfly Awaiting requested review from pigletfly

Assignees

@SataQiu SataQiu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cnfatal @SataQiu @k8s-ci-robot