Skip to content

translation cluster-intro#14393

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.14from
ChongmingDu:tutorials
May 21, 2019
Merged

translation cluster-intro#14393
k8s-ci-robot merged 1 commit intokubernetes:release-1.14from
ChongmingDu:tutorials

Conversation

@ChongmingDu
Copy link
Copy Markdown

@ChongmingDu ChongmingDu commented May 18, 2019 •
edited
Loading

For Chinese localization, base branch to release-1.14
---> /docs/tutorials/kubernetes-basics/create-cluster/cluster-intro.html
English pages have been updated, Chinese pages and the latest English pages do not match.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 18, 2019

Welcome @ChongmingDu!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 18, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 20, 2019
markthink
markthink reviewed May 20, 2019
View reviewed changes
Copy link
Copy Markdown

@markthink markthink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2019
chenrui333
chenrui333 reviewed May 21, 2019
View reviewed changes
content/zh/docs/tutorials/kubernetes-basics/cluster-intro.html

<div class="col-md-8">
<!-- <h3>Kubernetes Clusters</h3> -->
<h3>Kubernetes集群</h3>
Copy link
Copy Markdown
Member

@chenrui333 chenrui333 May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3>Kubernetes集群</h3>
<h3>Kubernetes 集群</h3>

chenrui333
chenrui333 approved these changes May 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenrui333
Copy link
Copy Markdown
Member

chenrui333 commented May 21, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333, markthink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 446fe03 into kubernetes:release-1.14 May 21, 2019
SataQiu pushed a commit to SataQiu/website that referenced this pull request Oct 9, 2019
@ChongmingDu @SataQiu
translation cluster-intro (kubernetes#14393)
a37f5c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@chentao1596 chentao1596 Awaiting requested review from chentao1596

2 more reviewers

@markthink markthink markthink left review comments

@chenrui333 chenrui333 chenrui333 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chenrui333 chenrui333

@markthink markthink

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChongmingDu @k8s-ci-robot @chenrui333 @markthink