Skip to content

Translation controller metrics in Bahasa Indonesia#14229

Merged
k8s-ci-robot merged 12 commits intokubernetes:masterfrom
danninov:id-translation-controller-metrics
May 8, 2019
Merged

Translation controller metrics in Bahasa Indonesia#14229
k8s-ci-robot merged 12 commits intokubernetes:masterfrom
danninov:id-translation-controller-metrics

Conversation

@danninov
Copy link
Copy Markdown
Contributor

@danninov danninov commented May 8, 2019

This PR addresses #13929

/language id

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from girikuncoro and irvifa May 8, 2019 13:02
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 8, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented May 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c9032ed

https://deploy-preview-14229--kubernetes-io-master-staging.netlify.com

@netlify
Copy link
Copy Markdown

netlify bot commented May 8, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b8ab3b3

https://deploy-preview-14229--kubernetes-io-master-staging.netlify.com

irvifa
irvifa suggested changes May 8, 2019
View reviewed changes
irvifa
irvifa suggested changes May 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's already good, also would like to use _ for italic instead of * to make the styling consistent with k8s styling guidelines.

@danninov
Copy link
Copy Markdown
Contributor Author

danninov commented May 8, 2019

Overall it's already good, also would like to use _ for italic instead of * to make the styling consistent with k8s styling guidelines.

Ah I didn't know that. I'll change the italic words to use _

irvifa
irvifa reviewed May 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@irvifa
Copy link
Copy Markdown
Member

irvifa commented May 8, 2019

Thanks @danninov 🎉

@k8s-ci-robot k8s-ci-robot merged commit 8f0fa1a into kubernetes:master May 8, 2019
@danninov danninov deleted the id-translation-controller-metrics branch May 9, 2019 10:34
@girikuncoro girikuncoro mentioned this pull request May 16, 2019
Closed
80 tasks
yoonian pushed a commit to yoonian/kubernetes-website that referenced this pull request May 28, 2019
@danninov @yoonian
Translation controller metrics in Bahasa Indonesia (kubernetes#14229)
702db84 
* Add new translation in Bahasa Indonesia

* Add revision to translation

* Edit type translation cloud-providers in Bahasa Indonesia

* Edit type translation cloud-providers

* Add translation Cluster Administration Overview in Bahasa Indonesia

* Delete cluster administration overview

* Add translation controller metrics in Bahasa Indonesia

* FIx type

* Fix type controller metrics

* Fix type and formatting
@danninov danninov mentioned this pull request Aug 8, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

1 more reviewer

@irvifa irvifa irvifa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irvifa irvifa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danninov @k8s-ci-robot @irvifa