translate Namespaces to Bahasa Indonesia#14128
Merged
k8s-ci-robot merged 4 commits intokubernetes:masterfrom May 7, 2019
zufardhiyaulhaq:master
Merged
translate Namespaces to Bahasa Indonesia#14128k8s-ci-robot merged 4 commits intokubernetes:masterfrom zufardhiyaulhaq:master
k8s-ci-robot merged 4 commits intokubernetes:masterfrom
zufardhiyaulhaq:master
Conversation
Contributor
Author
|
|
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 641b164 https://deploy-preview-14128--kubernetes-io-master-staging.netlify.com |
80 tasks
girikuncoro
requested changes
May 5, 2019
Contributor
girikuncoro
left a comment
There was a problem hiding this comment.
all looking good, just couple of minor nits then you are ready to go! thanks for contributing to Indonesian translation!
content/id/docs/concepts/overview/working-with-objects/namespaces.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/overview/working-with-objects/namespaces.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/overview/working-with-objects/namespaces.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/overview/working-with-objects/namespaces.md
Outdated
Show resolved
Hide resolved
girikuncoro
requested changes
May 5, 2019
Contributor
girikuncoro
left a comment
There was a problem hiding this comment.
all looking good, just some more nits, I will merge this after #14125 since it requires index.md
/lgtm
content/id/docs/concepts/overview/working-with-objects/namespaces.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/overview/working-with-objects/namespaces.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/overview/working-with-objects/namespaces.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/overview/working-with-objects/namespaces.md
Outdated
Show resolved
Hide resolved
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girikuncoro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #13929