Skip to content

Initialize Working with Objects translations for Bahasa Indonesia.#14125

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
irvifa:kubernetes-object
May 7, 2019
Merged

Initialize Working with Objects translations for Bahasa Indonesia.#14125
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
irvifa:kubernetes-object

Conversation

@irvifa
Copy link
Copy Markdown
Member

@irvifa irvifa commented May 2, 2019 •
edited
Loading

Initialize Working with Objects translations for Bahasa Indonesia.
This address #13929

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2019
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 2, 2019
@irvifa
Copy link
Copy Markdown
Member Author

irvifa commented May 2, 2019

/assign @girikuncoro

@girikuncoro girikuncoro mentioned this pull request May 2, 2019
Closed
80 tasks
@irvifa
Copy link
Copy Markdown
Member Author

irvifa commented May 2, 2019

FYI @zufardhiyaulhaq since you’re working on Namespaces

@netlify
Copy link
Copy Markdown

netlify bot commented May 2, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 176e03b

https://deploy-preview-14125--kubernetes-io-master-staging.netlify.com

@irvifa
Copy link
Copy Markdown
Member Author

irvifa commented May 2, 2019

/assign

zufardhiyaulhaq
zufardhiyaulhaq reviewed May 2, 2019
View reviewed changes
content/id/docs/concepts/overview/working-with-objects/kubernetes-objects.md Outdated
@@ -0,0 +1,109 @@
---
title: Memahami Konsep Objek-Objek yang Ada pada Kubernetes
Copy link
Copy Markdown
Contributor

@zufardhiyaulhaq zufardhiyaulhaq May 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital typo in Ada.

Copy link
Copy Markdown
Member Author

@irvifa irvifa May 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I was wondering if the only things that left non capitalized is conjunctions cc @girikuncoro

Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with standard Indonesian language for title, which in this case lowercase ada

@zufardhiyaulhaq zufardhiyaulhaq mentioned this pull request May 2, 2019
Merged
@girikuncoro girikuncoro removed the request for review from zhangxiaoyu-zidif May 3, 2019 10:39
girikuncoro
girikuncoro requested changes May 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment with #14117 , you should try reading this from https://deploy-preview-14125--kubernetes-io-master-staging.netlify.com/id/docs/concepts/overview/working-with-objects/kubernetes-objects/ . It is not easy to read because of backticks, which make sentences look cluttered. IMO we should use backticks wisely (only for commands, object field), and prefer normal/italic/camelcase style as much as possible.

wdyt?

content/id/docs/concepts/overview/working-with-objects/kubernetes-objects.md Outdated
@@ -0,0 +1,109 @@
---
title: Memahami Konsep Objek-Objek yang Ada pada Kubernetes
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with standard Indonesian language for title, which in this case lowercase ada

content/id/docs/concepts/overview/working-with-objects/kubernetes-objects.md Outdated
{{% capture body %}}
## Memahami Konsep Objek-Objek yang Ada pada Kubernetes

*Objek-Objek Kubernetes* adalah entitas `persisten` di dalam sistem Kubernetes.
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer doing italic for imported english words/terms, over backtick

we should follow this guideline for backtick (otherwise it will get harder and harder to read, as per my comments on #14117)
https://kubernetes.io/docs/contribute/style/style-guide/#inline-code-formatting

I don't think our Indonesian styleguide will differ from this. IMO our Indonesian styleguide should just be original english styleguide + italic imported english words (+ Indonesian specifics if any)

wdyt?

this comment applies for all imported words on backticks

Copy link
Copy Markdown
Member Author

@irvifa irvifa May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed..

girikuncoro
girikuncoro requested changes May 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good that right now we no longer see extensive use of backtick, but backtick is a bit tricky since we still need them for command and specs/fields of yaml definition.

review once more with https://deploy-preview-14125--kubernetes-io-master-staging.netlify.com/docs/concepts/overview/working-with-objects/kubernetes-objects/ , I think it's pretty safe to just follow their convention for this page on words formatted with backtick

@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented May 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2162101 into kubernetes:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girikuncoro girikuncoro girikuncoro requested changes

+1 more reviewer

@zufardhiyaulhaq zufardhiyaulhaq zufardhiyaulhaq left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@irvifa @girikuncoro @k8s-ci-robot @zufardhiyaulhaq