Initialize Service translations in Bahasa Indonesia.#14117
Initialize Service translations in Bahasa Indonesia.#14117k8s-ci-robot merged 4 commits intokubernetes:masterfrom
Conversation
|
/assign @girikuncoro |
|
/assign @irvifa |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 3230d61 https://deploy-preview-14117--kubernetes-io-master-staging.netlify.com |
girikuncoro
left a comment
There was a problem hiding this comment.
Great job on translating this long page! In general, this page has unnecessarily extensive backticks. You probably should review the page on netlify link. I would just do backticks for 3 things as per official english style https://kubernetes.io/docs/contribute/style/style-guide
how about following the official style also for API Objects with camel case?
girikuncoro
left a comment
There was a problem hiding this comment.
Careful that we still need the backticks for field names, flags, annotations, commands, etc. I think it's pretty safe to follow all backtick formats that original english page has (https://deploy-preview-14117--kubernetes-io-master-staging.netlify.com/docs/concepts/services-networking/service)
edit: just realized the english version has all backtick for API objects (do your self-judgement on this, since we haven't standardized the API objects formatting style)
girikuncoro
left a comment
There was a problem hiding this comment.
almost there, some more formatting issues then this PR is ready to get in
| ``` | ||
|
|
||
| _Policy_ ini kemudian dapat dispesifikasikan menggunakan anotasi | ||
| "_service.beta.kubernetes.io/aws-load-balancer-ssl-negotiation-policy_", contohnya: |
There was a problem hiding this comment.
service.beta.kubernetes.io/aws-load-balancer-ssl-negotiation-policy need to be in backtick
|
|
||
| Mekanisme _draining_ untuk ELB klasik dapat dilakukan dengan menggunakan anotasi | ||
| `service.beta.kubernetes.io/aws-load-balancer-connection-draining-enabled` serta mengatur | ||
| _value_-nya menjadi _"true"_. Anotasi |
There was a problem hiding this comment.
nit: true needs to be in backtick
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girikuncoro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Initialize translations for Service
This address #13929