Add translations for Ingress Controllers for Bahasa Indonesia#13959
Add translations for Ingress Controllers for Bahasa Indonesia#13959k8s-ci-robot merged 6 commits intokubernetes:masterfrom
Conversation
|
/language id |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit d11bb6f https://deploy-preview-13959--kubernetes-io-master-staging.netlify.com |
|
|
||
| Berbeda dengan kontroler-kontroler lainnya yang dijalankan | ||
| sebagai bagian dari <i>binary</i> `kube-controller-manager`, kontroler Ingress | ||
| tidak secara otomatis dijalankan di dalam kluster. Kamu bisa menggunakan |
There was a problem hiding this comment.
Hi @irvifa. Just looking at the new Bahasa Indonesia docs! Great job.
When I looked at the preview, this page listed as English. I was expecting to see Indonesian for this file?
Just a thought, do you need to use HTML markup in the markdown file, <i> ? Could use markdown instead, binary? I am not sure if the English version emphasizes binary, or is that the way you are emphasizing the English? Also, I don't think the front matter, title field needs emphasis.
There was a problem hiding this comment.
@kbhawkey On it, I create two separate PR tho, I'll push it to that PR later, it's because this lacks of _index.md inside the concepts directory.
For the <i> tag, we use that because we couldn't find a word that can describe that better in Bahasa Indonesia, great.. never thought about using the equivalent italic in markdown cc @girikuncoro
There was a problem hiding this comment.
It works like a charm, I can use the markdown 👍 and the translations working after I add index.md on the concepts. Will push it this afternoon. Thanks for noticing 🙇
girikuncoro
left a comment
There was a problem hiding this comment.
looking good, some comments on typos and left over english that needs translation
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| title: Kontroler <i>Ingress</i> | |||
| title: Kontroler *Ingress* | |||
There was a problem hiding this comment.
nit: You most likely can omit the emphasis of the title field of the front matter.
a69ef73 to
07c213d
Compare
girikuncoro
left a comment
There was a problem hiding this comment.
great job on translating this, 2 more minor changes, then we are done 🎉
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/id/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girikuncoro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |

This PR addresses #13929 and #13932