Skip to content

Add translations for Ingress Controllers for Bahasa Indonesia#13959

Merged
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
irvifa:id/add-ingress-controllers
Apr 25, 2019
Merged

Add translations for Ingress Controllers for Bahasa Indonesia#13959
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
irvifa:id/add-ingress-controllers

Conversation

@irvifa
Copy link
Copy Markdown
Member

@irvifa irvifa commented Apr 22, 2019

This PR addresses #13929 and #13932

  • ingress-controllers.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2019
@irvifa
Copy link
Copy Markdown
Member Author

irvifa commented Apr 22, 2019

/language id
/assign @girikuncoro

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d11bb6f

https://deploy-preview-13959--kubernetes-io-master-staging.netlify.com


Berbeda dengan kontroler-kontroler lainnya yang dijalankan
sebagai bagian dari <i>binary</i> `kube-controller-manager`, kontroler Ingress
tidak secara otomatis dijalankan di dalam kluster. Kamu bisa menggunakan
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irvifa. Just looking at the new Bahasa Indonesia docs! Great job.
When I looked at the preview, this page listed as English. I was expecting to see Indonesian for this file?
Just a thought, do you need to use HTML markup in the markdown file, <i> ? Could use markdown instead, binary? I am not sure if the English version emphasizes binary, or is that the way you are emphasizing the English? Also, I don't think the front matter, title field needs emphasis.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey On it, I create two separate PR tho, I'll push it to that PR later, it's because this lacks of _index.md inside the concepts directory.
For the <i> tag, we use that because we couldn't find a word that can describe that better in Bahasa Indonesia, great.. never thought about using the equivalent italic in markdown cc @girikuncoro

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works like a charm, I can use the markdown 👍 and the translations working after I add index.md on the concepts. Will push it this afternoon. Thanks for noticing 🙇

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed #13958

Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, some comments on typos and left over english that needs translation

@girikuncoro girikuncoro removed the request for review from stewart-yu April 23, 2019 05:50
@@ -1,5 +1,5 @@
---
title: Kontroler <i>Ingress</i>
title: Kontroler *Ingress*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You most likely can omit the emphasis of the title field of the front matter.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I think title doesn't support it as well

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, 👍

@irvifa irvifa force-pushed the id/add-ingress-controllers branch from a69ef73 to 07c213d Compare April 23, 2019 15:31
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job on translating this, 2 more minor changes, then we are done 🎉

@girikuncoro
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 83aadf6 into kubernetes:master Apr 25, 2019
@irvifa irvifa deleted the id/add-ingress-controllers branch April 25, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants