Skip to content

Translate ingress for Bahasa Indonesia.#13958

Merged
k8s-ci-robot merged 8 commits intokubernetes:masterfrom
irvifa:id/add-ingress
Apr 23, 2019
Merged

Translate ingress for Bahasa Indonesia.#13958
k8s-ci-robot merged 8 commits intokubernetes:masterfrom
irvifa:id/add-ingress

Conversation

@irvifa
Copy link
Copy Markdown
Member

@irvifa irvifa commented Apr 22, 2019

This PR addresses #13929 and #13933

  • ingress.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 22, 2019
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 22, 2019
@irvifa
Copy link
Copy Markdown
Member Author

irvifa commented Apr 22, 2019

/assign @girikuncoro

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 72fbb0b

https://deploy-preview-13958--kubernetes-io-master-staging.netlify.com

Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just be careful on typos and english left over.

Also the english link doesnt work, I would still do Indonesian link so once the referred translation is ready, it will get linked automatically

- src: "*beta*"
title: "beta"
- src: "*deprecated*"
title: "deprecated"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually maybe deprecated is better since it is in Kubernetes version convention, wdyt?

I might have to change whatever I've written that got merged to master later.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I second this

Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some more typos and english leftover

kontroler beroperasi sedikit berbeda satu sama lain.

{{< note >}}
Pastikan kamu sudah terlebih dahulu memahami dokumentasi kontroler Ingress yang akan kamu bakai sebelum memutuskan untuk memakai kontroler tersebut.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: bakai


### *Backend Default*

Sebuah Ingress yang tidak memiliki *rules* akan mengarahkan semua trafik pada sebuag *backend default*. *Backend default* inilah yang
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: sebuah

[readiness probes](/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/)
yang memungkinkan kamu untuk memperoleh hasil yang sama. Silahkan pelajari lebih lanjut dokumentasi
kontroler yang kamu pakai untuk mengetahui bagaimana implementasi *health checks* pada kontroler yang kamu pilih (
[nginx](https://git.k8s.io/ingress-nginx/README.md),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space on (


Setiap *rule* HTTP mengandung informasi berikut:

* *Host* opsional. Di dalam contoh ini, tidak ada *host* yang diberikan, dengan kata lain, semua *rules* berlaku untuk *inbound*.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing period for inbound

@girikuncoro
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2019
@irvifa
Copy link
Copy Markdown
Member Author

irvifa commented Apr 23, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro, irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3c4a42b into kubernetes:master Apr 23, 2019
@irvifa irvifa deleted the id/add-ingress branch April 23, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants