Skip to content

cri: add notes about changing cgroup driver#13899

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
neolit123:kubeadm-add-note-cgroup-change
Apr 22, 2019
Merged

cri: add notes about changing cgroup driver#13899
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
neolit123:kubeadm-add-note-cgroup-change

Conversation

@neolit123
Copy link
Copy Markdown
Member

@neolit123 neolit123 commented Apr 19, 2019 •
edited
Loading

/priority important-longterm
/sig cluster-lifecycle
@kubernetes/sig-cluster-lifecycle-pr-reviews

fixes kubernetes/kubeadm#1501

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 19, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 299a024

https://deploy-preview-13899--kubernetes-io-master-staging.netlify.com

@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented Apr 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2019
@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented Apr 21, 2019

/approve

@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented Apr 21, 2019

/assign @sig-docs-en-owners

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 21, 2019

@bart0sh: GitHub didn't allow me to assign the following users: sig-docs-en-owners.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @sig-docs-en-owners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented Apr 21, 2019

/cc @sig-docs-en-owners

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Apr 22, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0311519 into kubernetes:master Apr 22, 2019
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
@neolit123 @nowjean
cri: add notes about changing cgroup driver (kubernetes#13899)
e84a5a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincepri vincepri Awaiting requested review from vincepri

1 more reviewer

@bart0sh bart0sh bart0sh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bart0sh bart0sh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chicken and egg problem changing cgroup driver

4 participants

@neolit123 @bart0sh @k8s-ci-robot @tengqm