Document writing portable config with storage.#1311
Merged
erictune merged 1 commit intokubernetes:masterfrom Sep 27, 2016
Merged
Document writing portable config with storage.#1311erictune merged 1 commit intokubernetes:masterfrom
erictune merged 1 commit intokubernetes:masterfrom
Conversation
Contributor
Author
|
@viglesiasce you want this @thockin we just talked about this an hour ago |
9781f36 to
5350ae7
Compare
Contributor
|
Thanks so much @erictune!! Looks great! |
devin-donnelly
suggested changes
Sep 26, 2016
|
|
||
| ## Writing Portable Configuration | ||
|
|
||
| When writing configuration templates or examples that need persistent storage |
Contributor
There was a problem hiding this comment.
A little clearer if you reverse the order in this sentence.
"If you're writing configuration templates or examples that run on a wide range of clusters and need persistent storage, we recommend that you use the following pattern:"
| - Do not include PersistentVolume objects in the config, since the user instantiating the config may not have | ||
| permission to create PersistentVolumes. | ||
| - Give the user the option of providing a storage class name when instantating the template. | ||
| - If the user provides a storage class name, and the cluster is version 1.4 or newer, put that value into the `volume.beta.kubernetes.io/storage-class` annotation of the PVC. |
Contributor
There was a problem hiding this comment.
These next two bullets, related to storage class names, should be sub-bullets of the previous one (line 411).
5350ae7 to
746e0d6
Compare
Member
|
tech lgtm |
Contributor
Author
|
I addressed the doc reviewers comments so marking this Doc LGTM. |
746e0d6 to
ef07e50
Compare
Contributor
Author
|
Github Reviews doesn't seem to understand that I have addressed the review comments. |
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Sep 22, 2022
The URL for test app `trafficsplit` is wrong. Fixed. Signed-off-by: Vincent Yin <vincent.yin@narvar.com>
Okabe-Junya
pushed a commit
to Okabe-Junya/website
that referenced
this pull request
Dec 4, 2023
Multi tenancy completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is