Skip to content

ko: Add the Localization Korean page's link#12878

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
claudiajkang:update-link-README-ko
Apr 11, 2019
Merged

ko: Add the Localization Korean page's link#12878
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
claudiajkang:update-link-README-ko

Conversation

@claudiajkang
Copy link
Copy Markdown
Contributor

@claudiajkang claudiajkang commented Feb 27, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2019
@claudiajkang
Copy link
Copy Markdown
Contributor Author

claudiajkang commented Feb 27, 2019

/cc @gochist @ianychoi

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 27, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3b909da

https://deploy-preview-12878--kubernetes-io-master-staging.netlify.com

@claudiajkang claudiajkang force-pushed the update-link-README-ko branch from fadc429 to 3b909da Compare March 14, 2019 04:56
@claudiajkang
Copy link
Copy Markdown
Contributor Author

claudiajkang commented Mar 14, 2019

@gochist ping?

@gochist
Copy link
Copy Markdown
Contributor

gochist commented Mar 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2019
@ianychoi
Copy link
Copy Markdown
Member

ianychoi commented Mar 14, 2019

/lgtm

@ianychoi
Copy link
Copy Markdown
Member

ianychoi commented Mar 14, 2019

/approve

@claudiajkang
Copy link
Copy Markdown
Contributor Author

claudiajkang commented Mar 14, 2019

@gochist @ianychoi Thank you for the review

/assign @steveperry-53

@steveperry-53

This PR is a ko/owner had already reviewed it (gochist).
The ko/owner not have READEME-ko.md's approve permission.

Could you approve this PR?

@DanyC97
Copy link
Copy Markdown
Contributor

DanyC97 commented Mar 21, 2019

/language ko

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Mar 21, 2019
@gochist
Copy link
Copy Markdown
Contributor

gochist commented Apr 6, 2019 •
edited
Loading

@kubernetes/sig-docs-ko-owners do not have permission to approve this PR. It looks good to me as a native Korean speaker.

@zacharysarah
Copy link
Copy Markdown
Contributor

zacharysarah commented Apr 11, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ianychoi, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7faad1a into kubernetes:master Apr 11, 2019
TechinMama pushed a commit to TechinMama/website that referenced this pull request Apr 16, 2019
@claudiajkang @TechinMama
Add the Localization Korean page's link (kubernetes#12878)
2a4729f
@gochist gochist mentioned this pull request Apr 24, 2019
Closed
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
@claudiajkang @nowjean
Add the Localization Korean page's link (kubernetes#12878)
4921304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

@gochist gochist Awaiting requested review from gochist

@ianychoi ianychoi Awaiting requested review from ianychoi

Assignees

@gochist gochist

@ianychoi ianychoi

@steveperry-53 steveperry-53

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@claudiajkang @gochist @ianychoi @DanyC97 @zacharysarah @k8s-ci-robot @steveperry-53