Adjust for Minikube running RBAC by default#12851
Adjust for Minikube running RBAC by default#12851k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit b063416 https://deploy-preview-12851--kubernetes-io-master-staging.netlify.com |
Rajakavitha1
left a comment
There was a problem hiding this comment.
Thanks for the PR @sftim .
I suggest you update the content with details as mentioned in https://github.com/kubernetes-incubator/service-catalog/blob/master/docs/install.md#rbac
'now' is a very ambiguous word.
3b66077 to
3687085
Compare
|
Good suggestion @Rajakavitha1, thanks! |
Rajakavitha1
left a comment
There was a problem hiding this comment.
Thanks for the fix @sftim . May be "Minikube now has RBAC authorization enabled by default." is redundant.
3687085 to
b063416
Compare
|
I'm going to put this down to an execution ordering issue: I redid this PR before I had any coffee. |
|
Checked the updates on: https://deploy-preview-12851--kubernetes-io-master-staging.netlify.com/docs/tasks/service-catalog/install-service-catalog-using-helm/ /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rajakavitha1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix for #12751
Note that Minikube has RBAC enabled by default. Provide instructions just in case someone is using an older version.