docs: update acs-engine -> aks-engine#12804
docs: update acs-engine -> aks-engine#12804k8s-ci-robot merged 3 commits intokubernetes:masterfrom palmerabollo:patch-1
Conversation
acs-engine has been deprecated by Microsoft in favor of aks-engine
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit adc6b2a https://deploy-preview-12804--kubernetes-io-master-staging.netlify.com |
|
Thanks for your pull request @palmerabollo !!!!. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks. |
|
Signed |
|
|
||
| You can get started quickly by following the **[ACS-Engine Kubernetes Walkthrough](https://github.com/Azure/acs-engine/blob/master/docs/kubernetes.md)**. | ||
| You can get started quickly by following the **[ACS-Engine Kubernetes Tutorial](https://github.com/Azure/aks-engine/blob/master/docs/tutorials/README.md)**. | ||
|
|
There was a problem hiding this comment.
AKS-Engine Kubernetes Tutorial?
There was a problem hiding this comment.
Yes. The new repository (aks-engine) doesn't have a "Walkthrough" section.
There was a problem hiding this comment.
I think @kbhawkey means to update link text from "ACS-Engine Kubernetes Walkthrough" to "AKS-Engine Kubernetes Tutorial".
There was a problem hiding this comment.
Sorry, I'm stupid. Done.
| The resulting output is an Azure Resource Manager Template that can then be checked into source control and can then be used | ||
| to deploy Kubernetes clusters into Azure. | ||
| The input to AKS-Engine is similar to the Azure Resource Manager (ARM) template syntax used to deploy a cluster directly with the Azure Kubernetes Service.The resulting output is an ARM template that can then be checked into source control | ||
| and can then be used to deploy Kubernetes clusters into Azure. |
There was a problem hiding this comment.
- Could you further clarify the template input into AKS-Engine? Possibly break up first sentence.
- nit: no space after Azure Kubernetes Service.
- Suggestion: The resulting output is an ARM template that can be checked into source control and used to deploy Kubernetes clusters to Azure.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* docs: update acs-engine -> aks-engine acs-engine has been deprecated by Microsoft in favor of aks-engine * chore: PR feedback * fix missing AKS
* docs: update acs-engine -> aks-engine acs-engine has been deprecated by Microsoft in favor of aks-engine * chore: PR feedback * fix missing AKS
* docs: update acs-engine -> aks-engine acs-engine has been deprecated by Microsoft in favor of aks-engine * chore: PR feedback * fix missing AKS
acs-engine has been deprecated by Microsoft in favor of aks-engine.