Update command outputs to k8s 1.13 based#12771
Update command outputs to k8s 1.13 based#12771k8s-ci-robot merged 6 commits intokubernetes:masterfrom
Conversation
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 59f7ed0 https://deploy-preview-12771--kubernetes-io-master-staging.netlify.com |
There was a problem hiding this comment.
You should see that the cron job "hello" successfully scheduled a job at the time specified in LAST-SCHEDULE.
There are currently 0 active jobs, meaning that the job has completed or failed.
There is no specified time under LAST SCHEDULE in the output. I see only 50s. Also LAST-SCHEDULE is hyphenated?
Rajakavitha1
left a comment
There was a problem hiding this comment.
Mon Aug 29 21:34:09 UTC 2016
Hello from the Kubernetes cluster
Is this the output you see in k8s 1.13 as well? May be you can update the actual date and time you see in 1.13
|
Thanks for your PR @makocchi-git !!!! I checked the updates on https://deploy-preview-12771--kubernetes-io-master-staging.netlify.com/docs/tasks/job/automated-tasks-with-cron-jobs/ I just made some suggestions based on the changes you have made. |
Rajakavitha1
left a comment
There was a problem hiding this comment.
Because this is a task and there are steps. I suggest the following outline:
- Download the example corn job
- Check the status of the corn job
- Watch the job that is being created
- View the scheduled job
- View the pods that the last scheduled job created
a. Check the pod name
b. View the pod log
|
/assign @chenopis |
|
@chenopis Please review this PR for the output in 1.13. |
|
@Rajakavitha1 Thank you for your comments. I fixed following:
|
|
@makocchi-git One slight nit, then it looks good to go |
Co-Authored-By: makocchi-git <makocchi@gmail.com>
|
@zparnold Thank you for your review! |
|
@chenopis ping |
|
/lgtm |
|
Thanks for the PR, @makocchi-git! This is great! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cody-clark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update command outputs to k8s 1.13 based * Update command outputs to k8s 1.13 based (2) * Add the way to download the example manifest and change datetime in a pod log * create a job from remote url * Update content/en/docs/tasks/job/automated-tasks-with-cron-jobs.md Co-Authored-By: makocchi-git <makocchi@gmail.com>
No description provided.