Fix Ingress callouts, links, nav, and templating#12720
Merged
k8s-ci-robot merged 10 commits intokubernetes:masterfrom Feb 27, 2019
Merged
Fix Ingress callouts, links, nav, and templating#12720k8s-ci-robot merged 10 commits intokubernetes:masterfrom
k8s-ci-robot merged 10 commits intokubernetes:masterfrom
Conversation
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 1c1bd0b https://deploy-preview-12720--kubernetes-io-master-staging.netlify.com |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 844a55c https://deploy-preview-12720--kubernetes-io-master-staging.netlify.com |
Contributor
Author
|
Contributor
Author
|
PTAL Steve. This PR fixes some weird formatting that the shortcodes seem to introduce along with some other small fixes. /assign @steveperry-53 |
sftim
reviewed
Feb 20, 2019
| ```shell | ||
| 172.17.0.15 hello-world.info | ||
| ``` | ||
| ```shell |
Contributor
There was a problem hiding this comment.
This isn't a shell command (was also wrong in the original).
Contributor
Author
There was a problem hiding this comment.
Removed syntax according to #12783 (comment)
tengqm
reviewed
Feb 20, 2019
content/en/docs/concepts/services-networking/ingress-controllers.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/access-application-cluster/ingress-minikube.md
Outdated
Show resolved
Hide resolved
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveperry-53 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
kwiesmueller
pushed a commit
to kwiesmueller/website
that referenced
this pull request
Feb 28, 2019
* Fix Ingress callouts, links, nav, and templating * Update ingress.md * Update ingress-minikube.md * Delete .md that caused 404 * Delete .md that caused 404 * Update ingress-controllers.md * Update ingress-minikube.md * spell check pass * Update ingress.md * Update ingress-minikube.md
krmayankk
pushed a commit
to krmayankk/kubernetes.github.io
that referenced
this pull request
Mar 11, 2019
* Fix Ingress callouts, links, nav, and templating * Update ingress.md * Update ingress-minikube.md * Delete .md that caused 404 * Delete .md that caused 404 * Update ingress-controllers.md * Update ingress-minikube.md * spell check pass * Update ingress.md * Update ingress-minikube.md
yagonobre
pushed a commit
to yagonobre/website
that referenced
this pull request
Mar 14, 2019
* Fix Ingress callouts, links, nav, and templating * Update ingress.md * Update ingress-minikube.md * Delete .md that caused 404 * Delete .md that caused 404 * Update ingress-controllers.md * Update ingress-minikube.md * spell check pass * Update ingress.md * Update ingress-minikube.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small updates to previous Ingress doc rework