Skip to content

Fix a misleading word in containers/images.md#12553

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
seokho-son:fix-minor-images
Feb 12, 2019
Merged

Fix a misleading word in containers/images.md#12553
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
seokho-son:fix-minor-images

Conversation

@seokho-son
Copy link
Copy Markdown
Member

@seokho-son seokho-son commented Feb 8, 2019 •
edited
Loading

This PR update a minor misleading word in concepts/containers/images.md
(un-base64 encoded -> base64 decoded)

In https://kubernetes.io/docs/concepts/containers/images/#bypassing-kubectl-create-secrets ,
there is a sentence with "un-base64 encoded".

If you get the error message error: no objects passed to create, it may mean the base64 encoded string is invalid.
If you get an error message like Secret "myregistrykey" is invalid: data[.dockerconfigjson]: invalid value ..., it means the data was successfully un-base64 encoded, but could not be parsed as a .docker/config.json file.

I updated PR as follows,
it means the data was successfully un-base64 encoded
->
it means the base64 encoded string in the data was successfully decoded

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 8, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 8, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 28b7576

https://deploy-preview-12553--kubernetes-io-master-staging.netlify.com

@seokho-son
Copy link
Copy Markdown
Member Author

seokho-son commented Feb 8, 2019

Netlify preview for the changed section.
https://deploy-preview-12553--kubernetes-io-master-staging.netlify.com/docs/concepts/containers/images/#bypassing-kubectl-create-secrets

@rlenferink
Copy link
Copy Markdown
Member

rlenferink commented Feb 8, 2019

Isn't base64 decoded more appropriate here?

@seokho-son
Copy link
Copy Markdown
Member Author

seokho-son commented Feb 11, 2019

@rlenferink Thank you for the comment. I think you are right. I was confused.

I updated PR as follows,
it means the data was successfully un-base64 encoded
->
it means the base64 encoded string in the data was successfully decoded

@bradtopol bradtopol self-assigned this Feb 12, 2019
@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Feb 12, 2019

This reads better and is easier to comprehend. I checked the preview and it looks good as well.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit ffa83bb into kubernetes:master Feb 12, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@seokho-son
Fix a misleading word in containers/images.md (kubernetes#12553)
762180a 
* Fix a misleading word in containers/images.md

* Rev Fix a misleading word in containers/images.md
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@seokho-son
Fix a misleading word in containers/images.md (kubernetes#12553)
fcef6ac 
* Fix a misleading word in containers/images.md

* Rev Fix a misleading word in containers/images.md
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@seokho-son @yagonobre
Fix a misleading word in containers/images.md (kubernetes#12553)
e5e10a7 
* Fix a misleading word in containers/images.md

* Rev Fix a misleading word in containers/images.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erictune erictune Awaiting requested review from erictune

@thockin thockin Awaiting requested review from thockin

Assignees

@bradtopol bradtopol

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seokho-son @rlenferink @bradtopol @k8s-ci-robot