Skip to content

fix typo in install-kubeadm.md#12527

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
neomantra:patch-1
Feb 12, 2019
Merged

fix typo in install-kubeadm.md#12527
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
neomantra:patch-1

Conversation

@neomantra
Copy link
Copy Markdown
Contributor

@neomantra neomantra commented Feb 6, 2019

"Kubernetes control panel" instead of "Kubernetes control plane"

@neomantra
fix typo in install-kubeadm.md
5ba5a66 
"Kubernetes control panel" instead of "Kubernetes control plane"
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 6, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 6, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 6, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5ba5a66

https://deploy-preview-12527--kubernetes-io-master-staging.netlify.com

@neomantra
Copy link
Copy Markdown
Contributor Author

neomantra commented Feb 6, 2019

I signed it

@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Feb 6, 2019

/check-cla

@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Feb 6, 2019

please try contacting the CNCF support as it seems that your CLA was not activated.
once resolved you can come back here and call /check-cla in a comment.

neolit123
neolit123 approved these changes Feb 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @neomantra !
/lgtm
/sig cluster-lifecycle

should be ready to merge once the CLA issue is resolved.

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 6, 2019
@neomantra
Copy link
Copy Markdown
Contributor Author

neomantra commented Feb 6, 2019

/check-cla

1 similar comment
@neomantra
Copy link
Copy Markdown
Contributor Author

neomantra commented Feb 6, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 6, 2019
@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Feb 6, 2019

/assign @stewart-yu

@Rajakavitha1
Copy link
Copy Markdown
Contributor

Rajakavitha1 commented Feb 12, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit fc9a171 into kubernetes:master Feb 12, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@neomantra
fix typo in install-kubeadm.md (kubernetes#12527)
00231a7 
"Kubernetes control panel" instead of "Kubernetes control plane"
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@neomantra
fix typo in install-kubeadm.md (kubernetes#12527)
7832a9b 
"Kubernetes control panel" instead of "Kubernetes control plane"
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@neomantra @yagonobre
fix typo in install-kubeadm.md (kubernetes#12527)
60757f0 
"Kubernetes control panel" instead of "Kubernetes control plane"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

1 more reviewer

@neolit123 neolit123 neolit123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@neolit123 neolit123

@stewart-yu stewart-yu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neomantra @k8s-ci-robot @neolit123 @Rajakavitha1 @stewart-yu