Skip to content

Small refactor of Custom Resources topic#12502

Merged
k8s-ci-robot merged 1 commit intomasterfrom
custom-resources
Feb 28, 2019
Merged

Small refactor of Custom Resources topic#12502
k8s-ci-robot merged 1 commit intomasterfrom
custom-resources

Conversation

@mdlinville
Copy link
Copy Markdown
Contributor

@mdlinville mdlinville commented Feb 4, 2019

  • Adjusts levels
  • Removes some obsolete info
  • Rewrite of some of the intro material

@mdlinville mdlinville requested a review from nikhita February 4, 2019 18:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 4, 2019
@mdlinville
Copy link
Copy Markdown
Contributor Author

mdlinville commented Feb 4, 2019

/assign @steveperry-53

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8bdbc7d

https://deploy-preview-12502--kubernetes-io-master-staging.netlify.com

Small refactor of Custom Resources topic
8bdbc7d 
- Adjusts levels
- Removes some obsolete info
- Rewrite of some of the intro material
@mdlinville
Copy link
Copy Markdown
Contributor Author

mdlinville commented Feb 4, 2019

Addressed feedback by amending. PTAL :)

nikhita
nikhita approved these changes Feb 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for refactoring this, @MistyHacks! :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2019
@mdlinville
Copy link
Copy Markdown
Contributor Author

mdlinville commented Feb 4, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2019
kbhawkey
kbhawkey reviewed Feb 4, 2019
View reviewed changes
content/en/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
A *custom resource* is an extension of the Kubernetes API that is not necessarily available in a default
Kubernetes installation. It represents a customization of a particular Kubernetes installation. However,
many core Kubernetes functions are now built using custom resources, making Kubernetes more modular.

Copy link
Copy Markdown
Contributor

@kbhawkey kbhawkey Feb 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is it Kubernetes functions or Kubernetes resources, Kubernetes components?

Copy link
Copy Markdown
Contributor Author

@mdlinville mdlinville Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was more going for something like "functionality". I'll try to think how to reword this.

kbhawkey
kbhawkey reviewed Feb 4, 2019
View reviewed changes
content/en/docs/concepts/extend-kubernetes/api-extension/custom-resources.md

A [declarative API](/docs/concepts/overview/working-with-objects/kubernetes-objects/#understanding-kubernetes-objects)
allows you to _declare_ or specify the desired state of your resource and tries
to match the actual state to this desired state.
Copy link
Copy Markdown
Contributor

@kbhawkey kbhawkey Feb 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: state of your resource and tries to?

@Rajakavitha1
Copy link
Copy Markdown
Contributor

Rajakavitha1 commented Feb 21, 2019

Hi @MistyHacks looks like there are some review comments from @kbhawkey .
Could you please take a look at it.

@k8s-ci-robot k8s-ci-robot merged commit 928f709 into master Feb 28, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
Small refactor of Custom Resources topic (kubernetes#12502)
6d623a0 
- Adjusts levels
- Removes some obsolete info
- Rewrite of some of the intro material
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
Small refactor of Custom Resources topic (kubernetes#12502)
f6e2220 
- Adjusts levels
- Removes some obsolete info
- Rewrite of some of the intro material
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@yagonobre
Small refactor of Custom Resources topic (kubernetes#12502)
e6ca9fe 
- Adjusts levels
- Removes some obsolete info
- Rewrite of some of the intro material
@zacharysarah zacharysarah deleted the custom-resources branch March 28, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhita nikhita nikhita approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@enisoc enisoc Awaiting requested review from enisoc

+1 more reviewer

@kbhawkey kbhawkey kbhawkey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@steveperry-53 steveperry-53

@nikhita nikhita

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mdlinville @k8s-ci-robot @Rajakavitha1 @kbhawkey @nikhita @steveperry-53