Skip to content

Add markthink to Chinese review/approver teams#10683

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
zacharysarah:add-markthink-to-zh
Nov 1, 2018
Merged

Add markthink to Chinese review/approver teams#10683
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
zacharysarah:add-markthink-to-zh

Conversation

@zacharysarah
Copy link
Copy Markdown
Contributor

@zacharysarah zacharysarah commented Oct 19, 2018

Fixes #10682

This PR adds @markthink to SIG Docs review/approver teams for content/zh/.

This PR is on hold pending @markthink joining the K8s org.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 19, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added language/en Issues or PRs related to English language labels Oct 19, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2018
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Oct 19, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b1d4d64

https://deploy-preview-10683--kubernetes-io-master-staging.netlify.com

1 similar comment
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Oct 19, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b1d4d64

https://deploy-preview-10683--kubernetes-io-master-staging.netlify.com

@jimangel
Copy link
Copy Markdown
Member

jimangel commented Oct 19, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2018
@markthink
Copy link
Copy Markdown

markthink commented Oct 21, 2018

@zacharysarah thank you.

@zacharysarah
Copy link
Copy Markdown
Contributor Author

zacharysarah commented Oct 23, 2018

@markthink 👋 Ping for org membership--looks like you still need to open a new issue.

@zacharysarah zacharysarah mentioned this pull request Oct 23, 2018
Closed
2 tasks
@markthink markthink mentioned this pull request Oct 24, 2018
Closed
6 tasks
@markthink
Copy link
Copy Markdown

markthink commented Oct 24, 2018 •
edited
Loading

@zacharysarah ok, I have submitted the issue at kubernetes/org#186.
The current Chinese translation article is managed by Google Sheets, it translation process is [here] (https: //github.com/k8smeetup/k8s-official-translation/), I hope the email can be replied, what is the current participation rule, about this confused. thank you.

@zacharysarah
Copy link
Copy Markdown
Contributor Author

zacharysarah commented Oct 30, 2018

Unblocked by kubernetes/org#192

@cody-clark 👋 Ready for approval when you are.

/hold cancel
/assign @cody-clark

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2018
@zacharysarah
Copy link
Copy Markdown
Contributor Author

zacharysarah commented Oct 30, 2018

@markthink

I hope the email can be replied, what is the current participation rule, about this confused

Did this reply help? Please let me know.

@cody-clark
Copy link
Copy Markdown
Contributor

cody-clark commented Oct 30, 2018

/approve

@cody-clark
Copy link
Copy Markdown
Contributor

cody-clark commented Nov 1, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2c9690d into kubernetes:master Nov 1, 2018
@markthink
Copy link
Copy Markdown

markthink commented Nov 5, 2018

@zacharysarah OK，I will email the current translation process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

1 more reviewer

@jimangel jimangel jimangel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jimangel jimangel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zacharysarah @k8sio-netlify-preview-bot @jimangel @markthink @cody-clark @k8s-ci-robot @kubernetes-docs-i18n-bot