Skip to content

Add i18n strings for Korean translation#10611

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
gochist:ko-i18n-strings
Nov 4, 2018
Merged

Add i18n strings for Korean translation#10611
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
gochist:ko-i18n-strings

Conversation

@gochist
Copy link
Copy Markdown
Contributor

@gochist gochist commented Oct 14, 2018

related with #10602

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 14, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 14, 2018
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit 7a35933

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bc29b5cb31274084e0381bb

@gochist
Copy link
Copy Markdown
Contributor Author

gochist commented Oct 14, 2018

FYI, build failure is not caused by this change. It is reported by #10608 .

/cc @claudiajkang @ianychoi

Copy link
Copy Markdown
Member

@ianychoi ianychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gochist Please see my comment - thanks!

@@ -0,0 +1,82 @@
# i18n strings for the Korean translation.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> "# i18n strings for the Korean (translated) site." for consistency with "# i18n strings for the English (main) site."

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! But It is consistent with no.toml.

# i18n strings for the Korean translation.

[main_read_about]
other = "Read about"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "정보 읽기"? ('About' is difficult to translate in Korean.. Most 1:1 matching would be "관하여" but seems not proper to the context)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not naturally translated without changing the word order. Because this string is a part of the sentence and the word order is different between Korean and English. You can find the context of this string on the case studies page.

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit ba4a87b

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bc744be82d3f152eb272d4b

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Oct 17, 2018

Deploy preview for kubernetes-io-master-staging failed.

Built with commit 69db1b1

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bde614bc6aed63cdb83ba89

@gochist
Copy link
Copy Markdown
Contributor Author

gochist commented Oct 17, 2018

@ianychoi Thank you! I addressed your review.

@claudiajkang
Copy link
Copy Markdown
Contributor

claudiajkang commented Oct 17, 2018

@gochist I have one question!
Is there any specific reason that main_documentation_license and main_copyright_notice did not translate?

@gochist
Copy link
Copy Markdown
Contributor Author

gochist commented Oct 17, 2018

@claudiajkang I'm not sure that I can translate them legally right.

@ianychoi
Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2018
@gochist
Copy link
Copy Markdown
Contributor Author

gochist commented Oct 22, 2018

This PR is reviewed by l10n(ko) reviewers, @ianychoi and @claudiajkang .
Please take a look.
/assign @stewart-yu

@gochist
Copy link
Copy Markdown
Contributor Author

gochist commented Oct 30, 2018

@stewart-yu 👋 Please take a look.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2018
@gochist
Copy link
Copy Markdown
Contributor Author

gochist commented Nov 4, 2018

Rebased ontomaster to include #10811 so that i18n/OWNERS can review and approve this PR.
@ianychoi , @claudiajkang Please take a look.

@ianychoi
Copy link
Copy Markdown
Member

ianychoi commented Nov 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2018
@claudiajkang
Copy link
Copy Markdown
Contributor

/assign @claudiajkang
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ClaudiaJKang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit a9d8c54 into kubernetes:master Nov 4, 2018
chenopis added a commit that referenced this pull request Nov 5, 2018
k8s-ci-robot pushed a commit that referenced this pull request Nov 5, 2018
* Revert "Update tutorial to work with Katacoda, No Install (#10797)"

This reverts commit a0b97a3.

* Revert "clean-up minikube toc (#10873)"

This reverts commit 18343eb.

* Revert "Tutorial cleanup: Delete K8s 101 and 201 (#10786)"

This reverts commit e0168fd.

* Revert "fix word err in Disruption (#10884)"

This reverts commit d01b76d.

* Revert "Fix typo (#10877)"

This reverts commit 1551868.

* Revert "add note informing users of env var updates (#10819)"

This reverts commit 795de19.

* Revert "Fix typo in word repositories (#10883)"

This reverts commit 6d7f27e.

* Revert "Add i18n strings for Korean translation (#10611)"

This reverts commit a9d8c54.

* Revert "Modified into appropriate words (#10768)"

This reverts commit 7ebdd66.

* Revert "Update tools.md (#10753)"

This reverts commit 2d8bc15.

* Revert "Enable reviews/approvers for localized site strings (#10811)"

This reverts commit 81b2562.
@gochist gochist deleted the ko-i18n-strings branch September 22, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants