Run e2e tests inside Docker on PR Jenkins#432
Merged
ixdy merged 2 commits intokubernetes:masterfrom Aug 23, 2016
Merged
Conversation
Contributor
Author
|
This has the side effect of fixing kubernetes/kubernetes#31148 too (at least the |
Contributor
|
Looks reasonable to me. Lets merge tomorrow morning. |
Contributor
|
LGTM |
This was referenced Aug 23, 2016
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Aug 24, 2016
Automatic merge from submit-queue Explicitly set CLOUDSDK_CONFIG override early in e2e-runner I'm guessing this is why a number of gci-on-gke builds started failing after kubernetes/test-infra#432 was merged - we're overriding the gcloud configuration location from the default, so the activated service account no longer works. Previously we did this service activation late, but after we'd overridden the value. I've changed it to explicitly set to a known-good value every time at the very start. cc @vishh @maisem @spxtr @fejta
foxish
pushed a commit
to foxish/test-infra
that referenced
this pull request
Jan 21, 2017
[mungegithub] Only run ping-ci test on master
ostromart
pushed a commit
to ostromart/test-infra
that referenced
this pull request
Jul 26, 2019
grantr
pushed a commit
to grantr/test-infra
that referenced
this pull request
Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally fixes #318 (except for node e2e, which is still its own special snowflake).
Seems to work:
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/30539/kubernetes-pull-build-test-e2e-gce/55368/
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/30539/kubernetes-pull-build-test-e2e-gke/8973/
This change is