Skip to content

Run critical e2e tests using GCI in addition to container-vm#420

Merged
vishh merged 2 commits intokubernetes:masterfrom
vishh:gci-submit-queue-tests
Aug 22, 2016
Merged

Run critical e2e tests using GCI in addition to container-vm#420
vishh merged 2 commits intokubernetes:masterfrom
vishh:gci-submit-queue-tests

Conversation

@vishh
Copy link
Copy Markdown
Contributor

@vishh vishh commented Aug 20, 2016 •
edited by pwittrock
Loading

For kubernetes/kubernetes#25276
New GCP projects have been created already.

This change is Reviewable

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Aug 20, 2016

cc @dchen1107

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Aug 20, 2016

Marking as do-not-merge to wait for the gke project creations to complete.

@vishh vishh mentioned this pull request Aug 20, 2016
Merged
@wonderfly
Copy link
Copy Markdown
Contributor

wonderfly commented Aug 22, 2016

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gce.yaml, line 72 [r1] (raw file):

only job
Either the comment or export E2E_PUBLISH_GREEN_VERSION needs to be updated.

jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gce.yaml, line 77 [r1] (raw file):

KUBE_OS_DISTRIBUTION
I believe you should set KUBE_NODE_OS_DISTRIBUTION instead, here and all below, except jobs for releases-1.2 and earlier. Please take a look at the job configs in kubernetes-e2e-gce-gci.yaml for reference.

jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gke.yaml, line 75 [r1] (raw file):

KUBE_OS_DISTRIBUTION
Set KUBE_NODE_OS_DISTRIBUTION instead.

jenkins/job-configs/kubernetes-jenkins/kubernetes-soak.yaml, line 145 [r1] (raw file):

KUBE_OS_DISTRIBUTION
KUBE_NODE_OS_DISTRIBUTION

Comments from Reviewable

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Aug 22, 2016

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gce.yaml, line 77 [r1] (raw file):

Previously, wonderfly (Daniel Wang) wrote…

KUBE_OS_DISTRIBUTION
I believe you should set KUBE_NODE_OS_DISTRIBUTION instead, here and all below, except jobs for releases-1.2 and earlier. Please take a look at the job configs in kubernetes-e2e-gce-gci.yaml for reference.

Why can I not set `KUBE_OS_DISTRIBUTION`? This var takes precedence over `KUBE_NODE_IS_DISTRIBUTION` and ensure that both master and nodes run with GCI. This PR does not add release-1.2 tests.

jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gke.yaml, line 75 [r1] (raw file):

Previously, wonderfly (Daniel Wang) wrote…

KUBE_OS_DISTRIBUTION
Set KUBE_NODE_OS_DISTRIBUTION instead.

Why?

jenkins/job-configs/kubernetes-jenkins/kubernetes-soak.yaml, line 145 [r1] (raw file):

Previously, wonderfly (Daniel Wang) wrote…

KUBE_OS_DISTRIBUTION
KUBE_NODE_OS_DISTRIBUTION

Why?

Comments from Reviewable

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Aug 22, 2016

@wonderful PTAL

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

@wonderfly
Copy link
Copy Markdown
Contributor

wonderfly commented Aug 22, 2016

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gce.yaml, line 77 [r1] (raw file):

Previously, vishh (Vish Kannan) wrote…

Why can I not set KUBE_OS_DISTRIBUTION? This var takes precedence over KUBE_NODE_IS_DISTRIBUTION and ensure that both master and nodes run with GCI.
This PR does not add release-1.2 tests.

You are right. I am behind the config changes. `KUBE_OS_DISTRIBUTION` was deleted in favor of `KUBE_MASTER_OS_DISTRIBUTION` and `KUBE_NODE_OS_DISTRIBUTION` at some point.

Since you are doing this, maybe worth updating the configs in kubernetes-e2e-gce-gci.yaml to set just KUBE_OS_DISTRIBUTION too, to make things consistent across the board.

Comments from Reviewable

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Aug 22, 2016

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gce.yaml, line 72 [r1] (raw file):

Previously, wonderfly (Daniel Wang) wrote…

only job
Either the comment or export E2E_PUBLISH_GREEN_VERSION needs to be updated.

Done.

jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gce.yaml, line 77 [r1] (raw file):

Previously, wonderfly (Daniel Wang) wrote…

You are right. I am behind the config changes. KUBE_OS_DISTRIBUTION was deleted in favor of KUBE_MASTER_OS_DISTRIBUTION and KUBE_NODE_OS_DISTRIBUTION at some point.

Since you are doing this, maybe worth updating the configs in kubernetes-e2e-gce-gci.yaml to set just KUBE_OS_DISTRIBUTION too, to make things consistent across the board.

I'd prefer doing that in a separate PR

Comments from Reviewable

@wonderfly
Copy link
Copy Markdown
Contributor

wonderfly commented Aug 22, 2016

:lgtm:

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Aug 22, 2016

Note: I have disabled the gci scalability tests for now. I'm waiting for more quota. Meanwhile, the rest of the tests can be enabled.

cc @spxtr

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@spxtr
Copy link
Copy Markdown
Contributor

spxtr commented Aug 22, 2016

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@vishh vishh force-pushed the gci-submit-queue-tests branch 2 times, most recently from 81df816 to 7eceae1 Compare August 22, 2016 22:04
@vishh
Run critical e2e tests using GCI in addition to container-vm
a849517 
Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh vishh force-pushed the gci-submit-queue-tests branch from 7eceae1 to f04d1bf Compare August 22, 2016 22:11
@vishh
disable gci scalability tests until gcp quota has been increased for …
7d691ed 
…the scalability gcp project

Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh vishh force-pushed the gci-submit-queue-tests branch from f04d1bf to 7d691ed Compare August 22, 2016 22:12
@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Aug 22, 2016

Had to do a rebase. Merging this PR based on the LGTMs.

@vishh vishh merged commit 0352d70 into kubernetes:master Aug 22, 2016
ostromart pushed a commit to ostromart/test-infra that referenced this pull request Jul 26, 2019
@sebastienvas
Add release-note-none label for auto merge (kubernetes#420)
0886726
grantr pushed a commit to grantr/test-infra that referenced this pull request Feb 21, 2020
@adrcunha @knative-prow-robot
Remove outdated comment (kubernetes#420)
721353d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vishh @wonderfly @spxtr @googlebot