Skip to content

run e2e tests as presubmit for cloud-provider-gcp#32603

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
aojea:cpgcp_e2e
May 13, 2024
Merged

run e2e tests as presubmit for cloud-provider-gcp#32603
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
aojea:cpgcp_e2e

Conversation

@aojea
Copy link
Copy Markdown
Member

@aojea aojea commented May 13, 2024

This will allow us to run kubernetes/cloud-provider-gcp#683 on demand to validte the PR before merge

/assign @seans3 @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 13, 2024
@aojea aojea mentioned this pull request May 13, 2024
Merged
@jprzychodzen
Copy link
Copy Markdown
Contributor

jprzychodzen commented May 13, 2024

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, jprzychodzen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 985ae23 into kubernetes:master May 13, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 13, 2024

@aojea: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-gcp-presubmits.yaml using file config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml
Details

In response to this:

This will allow us to run kubernetes/cloud-provider-gcp#683 on demand to validte the PR before merge

/assign @seans3 @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jprzychodzen jprzychodzen Awaiting requested review from jprzychodzen

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@BenTheElder BenTheElder

@seans3 seans3

@jprzychodzen jprzychodzen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aojea @jprzychodzen @k8s-ci-robot @BenTheElder @seans3