Skip to content

kube-proxy Nftables GCE jobs#32472

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
aojea:nftables_ci
Apr 20, 2024
Merged

kube-proxy Nftables GCE jobs#32472
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
aojea:nftables_ci

Conversation

@aojea

@aojea aojea commented Apr 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Add jobs using GCE for the new kube-proxy nftables mode

@aojea

aojea commented Apr 18, 2024

Copy link
Copy Markdown
Member Author

/assign @danwinship

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testgrid sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 18, 2024
@k8s-ci-robot

k8s-ci-robot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2024
@aojea aojea changed the title Nftables ci kube-proxyu Nftables GCE jobs Apr 19, 2024
@aojea aojea changed the title kube-proxyu Nftables GCE jobs kube-proxy Nftables GCE jobs Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2024
danwinship
danwinship reviewed Apr 19, 2024
View reviewed changes

@danwinship danwinship left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah lgtm assuming it was mostly copied from another working job

Comment thread config/jobs/kubernetes/sig-network/sig-network-misc.yaml Outdated
@danwinship

danwinship commented Apr 20, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4a6ac06 into kubernetes:master Apr 20, 2024
@k8s-ci-robot

k8s-ci-robot commented Apr 20, 2024

Copy link
Copy Markdown
Contributor

@aojea: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml
Details

In response to this:

Add jobs using GCE for the new kube-proxy nftables mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DamianSawicki DamianSawicki mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei Awaiting requested review from bowei

@timwangmusic timwangmusic Awaiting requested review from timwangmusic

1 more reviewer

@danwinship danwinship danwinship left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@danwinship danwinship

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aojea @k8s-ci-robot @danwinship