Skip to content

use latest images for capi operator e2e tests#30077

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
Fedosin:capio127
Jul 13, 2023
Merged

use latest images for capi operator e2e tests#30077
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
Fedosin:capio127

Conversation

@Fedosin

@Fedosin Fedosin commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

For tests in the main branch we should use master images, as they contain the newest golang version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2023
@k8s-ci-robot

k8s-ci-robot commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2023
@Fedosin Fedosin mentioned this pull request Jul 12, 2023
Merged
@Fedosin Fedosin force-pushed the capio127 branch 2 times, most recently from 11c095a to 3749ad4 Compare July 13, 2023 09:03
@Fedosin
use latest images for capi operator e2e tests
2da964e 
For tests in the main branch we should use master images, as they
contain the newest golang version.
furkatgofurov7
furkatgofurov7 reviewed Jul 13, 2023
View reviewed changes

@furkatgofurov7 furkatgofurov7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit e8b989e into kubernetes:master Jul 13, 2023
@k8s-ci-robot

k8s-ci-robot commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

@Fedosin: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-operator-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-periodics-main.yaml
  • key cluster-api-operator-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-presubmits-main.yaml
Details

In response to this:

For tests in the main branch we should use master images, as they contain the newest golang version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furkatgofurov7

furkatgofurov7 commented Jul 13, 2023

Copy link
Copy Markdown
Member

@Fedosin can you please update PR description to match the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo Awaiting requested review from damdo

1 more reviewer

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@furkatgofurov7 furkatgofurov7

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fedosin @k8s-ci-robot @furkatgofurov7