fix: prepend iptables fixes for Azure jobs#23744
Conversation
c4da4aa to
ce2670b
Compare
ce2670b to
16dfe25
Compare
| command: | ||
| - runner.sh | ||
| args: | ||
| - ./scripts/ci-apidiff.sh |
There was a problem hiding this comment.
we technically don't need the workaround for jobs that run locally like this one, but I don't think it hurts to make the change everywhere
There was a problem hiding this comment.
I robotically made the iptables change here, but then backed it out for runs of ci-apidiff.sh once I realized they aren't failing. So this is just a cosmetic change in the end.
16dfe25 to
c681ff0
Compare
| iptables -t mangle -A POSTROUTING -p tcp --tcp-flags SYN,RST SYN -j TCPMSS --clamp-mss-to-pmtu && | ||
| ./scripts/ci-entrypoint.sh | ||
| - bash | ||
| - -c |
There was a problem hiding this comment.
This one was a bit funky since we were already calling bash -c (as arguments to ci-entrypoint.sh...). I think this will work.
e5302ff to
70aa43e
Compare
| ./gopherage html "${ARTIFACTS}/filtered.cov" > "${ARTIFACTS}/coverage.html" || result=$? | ||
| ./gopherage junit --threshold 0 "${ARTIFACTS}/filtered.cov" > "${ARTIFACTS}/junit_coverage.xml" || result=$? | ||
| exit $result | ||
| - bash |
There was a problem hiding this comment.
just to confirm, this is just formatting change and moving bash to args?
There was a problem hiding this comment.
Correct. Sorry for the extraneous diffs, I should have reverted those but they should be no-ops.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, chewong, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mboersma just realized we forgot https://github.com/kubernetes/test-infra/tree/70aa43e7e0a9bf6094fdfb8c9cede9c7f24f26ff/config/jobs/kubernetes/sig-cloud-provider/azure (to fix the tests in https://testgrid.k8s.io/provider-azure-master-signal), sorry for not noticing earlier. not going to hold the PR so it can merge and unblock PR tests but we should fix those separately |
|
@mboersma: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix for #23741 based on initial success of kubernetes-sigs/secrets-store-csi-driver#749 and #23743.
Tested in kubernetes-sigs/cluster-api-provider-azure#1731, seems to be working.