kubernetes-csi: better pre-merge testing of csi-release-tools#21995
Merged
k8s-ci-robot merged 1 commit intoApr 28, 2021
Conversation
Contributor
Author
|
/assign @msau42 |
e9a7b08 to
33e9a72
Compare
When making changes to csi-release-tools, we want to know in advance how that change will affect the repos that consume csi-release-tools.
33e9a72 to
9022f2a
Compare
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@pohly: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pohly
added a commit
to pohly/csi-release-tools
that referenced
this pull request
Apr 28, 2021
This will be used by special Prow pull jobs (kubernetes/test-infra#21995) to ensure that an update csi-release-tools works in consuming repos.
pohly
added a commit
to pohly/csi-release-tools
that referenced
this pull request
Apr 28, 2021
This will be used by special Prow pull jobs (kubernetes/test-infra#21995) to ensure that an update csi-release-tools works in consuming repos.
pohly
added a commit
to pohly/csi-release-tools
that referenced
this pull request
Apr 28, 2021
This will be used by special Prow pull jobs (kubernetes/test-infra#21995) to ensure that an update csi-release-tools works in consuming repos.
pohly
added a commit
to pohly/csi-release-tools
that referenced
this pull request
Apr 28, 2021
This will be used by special Prow pull jobs (kubernetes/test-infra#21995) to ensure that an update csi-release-tools works in consuming repos.
pohly
added a commit
to pohly/csi-release-tools
that referenced
this pull request
Apr 28, 2021
This will be used by special Prow pull jobs (kubernetes/test-infra#21995) to ensure that an update csi-release-tools works in consuming repos.
pohly
added a commit
to pohly/csi-release-tools
that referenced
this pull request
Apr 29, 2021
This will be used by special Prow pull jobs (kubernetes/test-infra#21995) to ensure that an update csi-release-tools works in consuming repos.
pohly
added a commit
to pohly/csi-release-tools
that referenced
this pull request
Apr 29, 2021
This will be used by special Prow pull jobs (kubernetes/test-infra#21995) to ensure that an update csi-release-tools works in consuming repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making changes to csi-release-tools, we want to know in advance
how that change will affect the repos that consume csi-release-tools.
Related-to: kubernetes-csi/csi-release-tools#130
More work will be needed in csi-release-tools itself (the pull-test.sh script does not exist yet).
Defining these jobs is a first step.