kubernetes-csi 1.20, II#20596
Conversation
While the patch number no longer matters for the cluster setup, it's still needed for checking out the E2E tests of the Kubernetes release: Mon Jan 25 18:57:32 UTC 2021 go1.15.5 /home/prow/go/src/k8s.io/kubernetes$ git checkout v1.17 error: pathspec 'v1.17' did not match any file(s) known to git ERROR: checking out https://github.com/kubernetes/kubernetes v1.17 failed We could go back to specifying Kubernetes releases with major/minor/patch number inside the gen-jobs.sh script. But so far tests typically haven't been updated after the initial release, so appending .0 seems simpler than that.
Although jobs for 1.20 are not required to succeed, they do run automatically and 1.17 is not supported anymore. Therefore we can limit the testing to the last three releases and drop 1.17.
|
/assign @msau42 |
| # by periodic jobs (see https://k8s-testgrid.appspot.com/sig-storage-csi-ci#Summary). | ||
| - name: CSI_PROW_KUBERNETES_VERSION | ||
| value: "$kubernetes" | ||
| value: "$kubernetes.0" |
There was a problem hiding this comment.
This might be ok for now, but sometimes there are bug fixes or changes to tests made in patch versions that we may want.
There was a problem hiding this comment.
Yes. Addressing that then will be a bigger change to the gen-jobs.sh script again - more that I wanted to tackle now.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pohly: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a update for #20559 which fixes two things: