Use 1.14 for old branch test and use the correct image.#15436
Use 1.14 for old branch test and use the correct image.#15436k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
|
/assign @yujuhong |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| containers: | ||
| - name: pull-cri-containerd-node-e2e | ||
| image: gcr.io/k8s-testimages/kubekins-e2e:v20191127-ee0721a-master | ||
| image: gcr.io/k8s-testimages/kubekins-e2e:v20191127-ee0721a-1.15 |
There was a problem hiding this comment.
This job tests against the master branch in k8s; why use a 1.15 image?
There was a problem hiding this comment.
It is testing against 1.15m right?
- org: kubernetes
repo: kubernetes
base_ref: release-1.15
There was a problem hiding this comment.
You're right.
I think the fact that all the jobs are named "pull-cri-containerd-node-e2e" confused me....
|
/lgtm |
|
@Random-Liu: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1.12 and 1.13 are end of life, so update to 1.14.
Golang in master is updated to 1.13, which doesn't work with old Kubernetes branch. See kubernetes/kubernetes#82531
Signed-off-by: Lantao Liu lantaol@google.com