Skip to content

Add blockade for NEXT_KEP_NUMBER in k/enhancements#10856

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justaugustus:kep-num
Jan 25, 2019
Merged

Add blockade for NEXT_KEP_NUMBER in k/enhancements#10856
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justaugustus:kep-num

Conversation

@justaugustus
Copy link
Copy Markdown
Member

@justaugustus justaugustus commented Jan 21, 2019

Enforces the removal of NEXT_KEP_NUMBER in kubernetes/enhancements#703.
Rel: kubernetes/community#2245

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @calebamiles @spiffxp

/hold
(until kubernetes/enhancements#703 merges)

@justaugustus
Add blockade for NEXT_KEP_NUMBER in k/enhancements
e592cc0 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 21, 2019
@justaugustus justaugustus mentioned this pull request Jan 21, 2019
Merged
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Jan 21, 2019

/assign @cjwagner

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Jan 21, 2019

/sig pm

@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jan 22, 2019

/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 22, 2019
cjwagner
cjwagner approved these changes Jan 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 22, 2019

LGTM label has been added.

DetailsGit tree hash: ee63336a3f05317673018de407442a58925ee43d

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Jan 25, 2019

I'm going to remove the hold on this.
Changes to NEXT_KEP_NUMBER create undue review requests from top-level KEP reviewers.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit b55dea0 into kubernetes:master Jan 25, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 25, 2019

@justaugustus: Updated the plugins configmap using the following files:

  • key plugins.yaml using file prow/plugins.yaml
Details

In response to this:

Enforces the removal of NEXT_KEP_NUMBER in kubernetes/enhancements#703.
Rel: kubernetes/community#2245

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @calebamiles @spiffxp

/hold
(until kubernetes/enhancements#703 merges)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjwagner cjwagner cjwagner approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@spiffxp spiffxp

@calebamiles calebamiles

@cjwagner cjwagner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justaugustus @spiffxp @k8s-ci-robot @cjwagner @calebamiles