Skip to content

Move values.md from steering to the community repo#88

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nikhita:move-values
Jan 16, 2019
Merged

Move values.md from steering to the community repo#88
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nikhita:move-values

Conversation

@nikhita
Copy link
Copy Markdown
Member

@nikhita nikhita commented Jan 16, 2019

This PR removes values.md from the steering repo and kubernetes/community#3103 adds it to the community repo.

Since this document talks about community values, it seems apt to place it in the "kubernetes/community" repo and have it be more discoverable.

/cc @dims @spiffxp @sarahnovotny @parispittman @cblecker

/sig contributor-experience
/committee steering
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jan 16, 2019
@k8s-ci-robot k8s-ci-robot requested review from cblecker and dims January 16, 2019 14:15
@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Jan 16, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2019
Copy link
Copy Markdown
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhita I'd suggest keeping the file as a placeholder to preserve links; but move the existing content to a new location.

A sample how we did it with k/enhancements - kubernetes/enhancements#632.

Also add a placeholder link to maintain references to this document.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2019
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Jan 16, 2019

@idvoretskyi 👍 Done.

@philips
Copy link
Copy Markdown
Contributor

philips commented Jan 16, 2019

discussed during @kubernetes/steering-committee meeting.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, philips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jan 16, 2019

/hold cancel
Thanks @nikhita !

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit a2f4fc8 into kubernetes:master Jan 16, 2019
@nikhita nikhita deleted the move-values branch January 17, 2019 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants