Skip to content

Tombstone EXCEPTIONS.md#632

Merged
justaugustus merged 1 commit intokubernetes:masterfrom
justaugustus:exceptions
Oct 26, 2018
Merged

Tombstone EXCEPTIONS.md#632
justaugustus merged 1 commit intokubernetes:masterfrom
justaugustus:exceptions

Conversation

@justaugustus
Copy link
Copy Markdown
Member

@justaugustus justaugustus commented Oct 24, 2018 •
edited
Loading

This PR redirects contributors to k/sig-release for up-to-date information on the exceptions process.
It should only merge after kubernetes/sig-release#349 does.

/hold
/assign @idvoretskyi @kacole2

Signed-off-by: Stephen Augustus foo@agst.us

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 24, 2018
@k8s-ci-robot k8s-ci-robot requested a review from jdumars October 24, 2018 06:40
@justaugustus justaugustus mentioned this pull request Oct 24, 2018
Merged
idvoretskyi
idvoretskyi suggested changes Oct 24, 2018
View reviewed changes
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Oct 24, 2018

@idvoretskyi -- kubernetes/sig-release#349 is merged now (thanks!), so that link is live. Feel free to approve when you have a chance. :)

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2018
idvoretskyi
idvoretskyi reviewed Oct 24, 2018
View reviewed changes
@justaugustus
Tombstone EXCEPTIONS.md
5ea1d01 
Signed-off-by: Stephen Augustus <foo@agst.us>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 26, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: idvoretskyi

If they are not already assigned, you can assign the PR to them by writing /assign @idvoretskyi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Oct 26, 2018

I'm manually merging this to ensure there's no confusion as Enhancements Freeze has passed.

@justaugustus justaugustus merged commit 7c7d3d6 into kubernetes:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calebamiles calebamiles Awaiting requested review from calebamiles

@jdumars jdumars Awaiting requested review from jdumars

2 more reviewers

@idvoretskyi idvoretskyi idvoretskyi requested changes

@idealhack idealhack idealhack left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@idvoretskyi idvoretskyi

@kacole2 kacole2

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justaugustus @k8s-ci-robot @idvoretskyi @idealhack @kacole2