Skip to content

Remove the values.md tombstone file#100

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nikhita:remove-values
Apr 30, 2019
Merged

Remove the values.md tombstone file#100
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nikhita:remove-values

Conversation

@nikhita
Copy link
Copy Markdown
Member

@nikhita nikhita commented Apr 22, 2019

The original content was moved to the community repo in January in 412bdfa, which is almost three months ago now.

Additionally, all references pointing to this file now point to the file in the community repo: https://github.com/search?q=org%3Akubernetes+org%3Akubernetes-sigs+org%3Akubernetes-incubator+org%3Akubernetes-csi+org%3Akubernetes-client+%22values.md%22&type=Code

Edit: except in old blog posts, created kubernetes/website#13954 for it.

/cc @spiffxp @dims

The original content was moved to the community repo in January (three
months ago): https://github.com/kubernetes/community/blob/master/values.md
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp April 22, 2019 11:33
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2019
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Apr 22, 2019

/approve
/hold
Until blog changes have merged

This may still cause dead links for any external sites that happen to link here. But I’d rather reduce tombstones then let them live in perpetuity. Such is the peril of using GitHub directly as our cms.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2019
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Apr 26, 2019

/hold cancel

The blog change PR has merged: kubernetes/website#13954

@spiffxp can I get a lgtm on this? :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2019
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Apr 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fff8b78 into kubernetes:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants