Skip to content

add machine requirement to run branchff#845

Closed
cpanato wants to merge 1 commit intokubernetes:masterfrom
cpanato:update_branchff
Closed

add machine requirement to run branchff#845
cpanato wants to merge 1 commit intokubernetes:masterfrom
cpanato:update_branchff

Conversation

@cpanato
Copy link
Copy Markdown
Member

@cpanato cpanato commented Nov 1, 2019

When running branchff in my local vagrant machine it took a long time to run and failed due out of memory.

checking the config it was only 1Gb and 1 vcpu to that VM.

  • spin a node in DO with 4vcpu/8gb and it ran ok and did another test with 6vpcu/16Gb which this last one was much better.

adding a note in the Branchff for the machine requirement to not loose time as me :)

/area release-team
/sig release
/cc @kubernetes/release-team
/cc @justaugustus

@cpanato
add machine requirement to run branchff
504ba19 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 1, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato
To complete the pull request process, please assign dougm
You can assign the PR to them by writing /assign @dougm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 1, 2019
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Nov 1, 2019

/hold
I started a discussion in Slack, as I'd like us to defer to some canonical reference point for system requirements for Kubernetes developers, if one exists.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2019
@liggitt liggitt mentioned this pull request Nov 1, 2019
Merged
@guineveresaenger guineveresaenger removed the area/release-team Issues or PRs related to the release-team subproject label Nov 11, 2019
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jan 27, 2020

branchff no longer updates the OpenAPI spec, so this isn't required anymore.

ref: kubernetes/release#921
/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 27, 2020

@justaugustus: Closed this PR.

Details

In response to this:

branchff no longer updates the OpenAPI spec, so this isn't required anymore.

ref: kubernetes/release#921
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

No one assigned

Labels

area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpanato @k8s-ci-robot @justaugustus @guineveresaenger