branchff: Remove hack/update-openapi-spec.sh run from tool#921
branchff: Remove hack/update-openapi-spec.sh run from tool#921k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
This is an optimization, which also allows us to perform a true branch fast-forward using "branchff". Prior to this commit, we were running hack/update-openapi-spec.sh, which: - installs a bunch of prerequisites, including etcd - builds the apiserver - runs an apiserver to retrieve the OpenAPI spec - rewrites a version field within the resulting swagger.json to match the targeted release branch And then we commit the result before pushing to the upstream release branch. This is obviously wasteful and runs contrary to the definition of a fast-forward. A fix to "null" the version field in the swagger.json has been submitted, so this commit removes that script logic to match. Signed-off-by: Stephen Augustus <saugustus@vmware.com>
|
@justaugustus: Adding label: DetailsReasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Do we need to wait for kubernetes/kubernetes#84654 get merged? |
|
looks much more like a fast-forward |
yes, that's why it is held |
|
also, for release-1.17, the first fast forward after kubernetes/kubernetes#84654 merges will not be clean. you might need to wait until after the next fast-forward to merge this |
I can do a fast-forward immediately afterwards or just wait til Monday. :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dougm, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
(Still on hold until we close the loop on kubernetes/kubernetes#84654.) |
|
kubernetes/kubernetes#84654 has merged. |
This is an optimization, which also allows us to perform a true branch
fast-forward using "branchff".
Prior to this commit, we were running hack/update-openapi-spec.sh,
which:
the targeted release branch
And then we commit the result before pushing to the upstream release
branch.
This is obviously wasteful and runs contrary to the definition of a
fast-forward.
A fix to "null" the version field in the swagger.json has been
submitted, so this commit removes that script logic to match.
Signed-off-by: Stephen Augustus saugustus@vmware.com
Until kubernetes/kubernetes#84654 merges:
/hold
/assign @liggitt @cpanato @Katharine @tpepper
/priority important-soon
/kind cleanup
/milestone v1.17
ref: https://kubernetes.slack.com/archives/C1TU9EB9S/p1572627769216100