Skip to content

Fix typo in /root/.docker/config.json#618

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
dims:fix-typo-in-docker-config-json
Sep 4, 2018
Merged

Fix typo in /root/.docker/config.json#618
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
dims:fix-typo-in-docker-config-json

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Sep 4, 2018

mis-placed single quote

@dims
Fix typo in /root/.docker/config.json
4e6cfcd 
Change-Id: Icd5569d12fe9ff198974620ff35df20871e6134a
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2018
tpepper
tpepper approved these changes Sep 4, 2018
View reviewed changes
Copy link
Copy Markdown

@tpepper tpepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2018
@calebamiles
Copy link
Copy Markdown
Contributor

calebamiles commented Sep 4, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles, dims, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [calebamiles,tpepper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 93b1c10 into kubernetes:master Sep 4, 2018
calebamiles pushed a commit to calebamiles/release that referenced this pull request Sep 5, 2018
Revert "Merge pull request kubernetes#618 from dims/fix-typo-in-docke…
af98481 
…r-config-json"

This reverts commit 93b1c10, reversing
changes made to e9f40b8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tpepper tpepper tpepper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tpepper tpepper

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dims @calebamiles @k8s-ci-robot @tpepper