Skip to content

build go1.21 images with base debian bookworm#3212

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
cpanato:golang121
Aug 22, 2023
Merged

build go1.21 images with base debian bookworm#3212
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
cpanato:golang121

Conversation

@cpanato
Copy link
Copy Markdown
Member

@cpanato cpanato commented Aug 18, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • golang: Build 1.21 images

/hold
/assign @saschagrunert @ameukam @Verolop @palnabarun
cc @kubernetes/release-managers @liggitt

Which issue(s) this PR fixes:

Related to #3076

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- golang: Build 1.21 images

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023
@cpanato
build go1.21 images with base debian bookworm
9939e0c 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 18, 2023

/test pull-release-image-kubepkg

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 18, 2023

/test pull-release-image-releng-ci

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 18, 2023

/test pull-release-image-go-runner

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 18, 2023

/test pull-release-image-k8s-ci-builder

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 18, 2023

/test pull-release-image-kube-cross

saschagrunert
saschagrunert approved these changes Aug 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 21, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Aug 22, 2023

/test pull-release-image-kubepkg

@saschagrunert saschagrunert reopened this Aug 22, 2023
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 22, 2023

/test pull-release-image-kubepkg

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 22, 2023

/test pull-release-image-go-runner

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 22, 2023

/test pull-release-image-k8s-ci-builder
/test pull-release-integration-test

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 22, 2023

/test pull-release-image-releng-ci

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 22, 2023

/test pull-release-image-kube-cross

1 similar comment
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Aug 22, 2023

/test pull-release-image-kube-cross

@k8s-ci-robot k8s-ci-robot merged commit 29bb779 into kubernetes:master Aug 22, 2023
@cpanato cpanato deleted the golang121 branch August 22, 2023 13:30
@cpanato cpanato mentioned this pull request Aug 23, 2023
Closed
36 tasks
akhilerm added a commit to akhilerm/publishing-bot that referenced this pull request Aug 31, 2023
@akhilerm
set CGO_ENABLED=0 for compiling publishing-bot
d4c83db 
set CGO_ENABLED=0, so that static binaries are generated for the various
publishing-bot components. This is needed because, when the build image
`gcr.io/k8s-staging-releng/k8s-ci-builder:latest-default` was upgraded
from bullseye to bookworm (kubernetes/release#3212), glibc version
incompatibility occurred between the build machine and the prod cluster,
preventing the bot from starting up.

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm mentioned this pull request Aug 31, 2023
Merged
akhilerm added a commit to akhilerm/publishing-bot that referenced this pull request Aug 31, 2023
@akhilerm
set CGO_ENABLED=0 for compiling publishing-bot
f16018d 
- set CGO_ENABLED=0, so that static binaries are generated for the
various publishing-bot components. This is needed because, when the
build image `gcr.io/k8s-staging-releng/k8s-ci-builder:latest-default`
was upgraded from bullseye to bookworm (kubernetes/release#3212), glibc
version incompatibility occurred between the build machine and the prod
cluster, preventing the bot from starting up.
- remove GO111MODULE=on, since in the latest versions of go that is used
for building the bot, go modules are used by default.

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@MadhavJivrajani MadhavJivrajani mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@jrsapi jrsapi Awaiting requested review from jrsapi

Assignees

@saschagrunert saschagrunert

@Verolop Verolop

@ameukam ameukam

@palnabarun palnabarun

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cpanato @k8s-ci-robot @saschagrunert @Verolop @ameukam @palnabarun