Skip to content

Adding sig-docs-vi members#1323

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
truongnh1992:sig-docs-vi-members
Oct 19, 2019
Merged

Adding sig-docs-vi members#1323
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
truongnh1992:sig-docs-vi-members

Conversation

@truongnh1992
Copy link
Copy Markdown
Member

@truongnh1992 truongnh1992 commented Oct 18, 2019

Owners and reviewers for the Vietnamese translation team
joined at kubernetes/website#16965

Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2019
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Oct 18, 2019

/assign zacharysarah

@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Oct 18, 2019

/test pull-org-test-all

@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Oct 18, 2019

/retest

@nikhita
Copy link
Copy Markdown
Member

nikhita commented Oct 18, 2019

The test fails due to:

The following members of team sig-docs-vi-reviews are not Kubernetes org members: annp1987, longkb, tiendc

IMHO you can add just @ngtuna and yourself for now, and once others start reviewing/sending PRs for Vietnamese localization, we can add them as org members (and eventually to the team).

@zacharysarah
Copy link
Copy Markdown

zacharysarah commented Oct 18, 2019

@truongnh1992 Agreed 💯 with @nikhita, please limit this PR to yourself and @ngtuna for now. You can add others once they've become members.

@zacharysarah zacharysarah mentioned this pull request Oct 18, 2019
Merged
Adding sig-docs-vi members
4803d86 
Owners and reviewers for the Vietnamese translation team
joined at kubernetes/website#16965

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Oct 19, 2019

The test fails due to:

The following members of team sig-docs-vi-reviews are not Kubernetes org members: annp1987, longkb, tiendc

IMHO you can add just @ngtuna and yourself for now, and once others start reviewing/sending PRs for Vietnamese localization, we can add them as org members (and eventually to the team).

Thank you @nikhita I've just updated the list.

@jimangel
Copy link
Copy Markdown
Member

jimangel commented Oct 19, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel, truongnh1992

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 52f01fa into kubernetes:master Oct 19, 2019
@truongnh1992 truongnh1992 mentioned this pull request Dec 23, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@zacharysarah zacharysarah

@jimangel jimangel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@truongnh1992 @nikhita @zacharysarah @jimangel @k8s-ci-robot