Skip to content

Revert "Enable snapshot e2e test for csi pd driver"#85322

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
davidz627:revert-85169-enable_snapshot_e2e_test_for_pd
Nov 15, 2019
Merged

Revert "Enable snapshot e2e test for csi pd driver"#85322
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
davidz627:revert-85169-enable_snapshot_e2e_test_for_pd

Conversation

@davidz627
Copy link
Copy Markdown
Contributor

@davidz627 davidz627 commented Nov 15, 2019 •
edited
Loading

Reverts #85169

The tests that were turned on were never tested in the pull job pull-kubernetes-e2e-gce-alpha-features
It seems like other PR's are now running this job and failing.

/assign @msau42 @boylee1111

NONE

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 15, 2019

@davidz627: GitHub didn't allow me to assign the following users: boylee1111.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

Reverts #85169

The tests that were turned on were never tested in the pull job pull-kubernetes-e2e-gce-alpha-features
It seems like other PR's are now running this job and failing.

/assign @msau42 @boylee1111

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2019
@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Nov 15, 2019

/sig storage
/priority critical-urgent
/kind test-failure

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 15, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 15, 2019

@davidz627: The label(s) kind/test-failure cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

Details

In response to this:

/sig storage
/priority critical-urgent
/kind test-failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 15, 2019
@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Nov 15, 2019

/kind failing-test

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 15, 2019
@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Nov 15, 2019

/cc @ddebroy

@k8s-ci-robot k8s-ci-robot requested a review from ddebroy November 15, 2019 03:32
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@msau42
Copy link
Copy Markdown
Member

msau42 commented Nov 15, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidz627 davidz627 mentioned this pull request Nov 15, 2019
Merged
@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Nov 15, 2019

Most recent CI run as well: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-alpha-features/1195171726233702402

@ddebroy
Copy link
Copy Markdown
Contributor

ddebroy commented Nov 15, 2019

/retest

1 similar comment
@ddebroy
Copy link
Copy Markdown
Contributor

ddebroy commented Nov 15, 2019

/retest

@ddebroy
Copy link
Copy Markdown
Contributor

ddebroy commented Nov 15, 2019

/test pull-kubernetes-node-e2e-containerd

@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Nov 15, 2019

/retest

@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Nov 15, 2019

pull-kubernetes-node-e2e-containerd test has been failing consistently across PRs for the last 4ish hours

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Nov 15, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 15, 2019

@davidz627: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e-containerd 1f25884 link /test pull-kubernetes-node-e2e-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit e4bde52 into kubernetes:master Nov 15, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 15, 2019
@davidz627 davidz627 deleted the revert-85169-enable_snapshot_e2e_test_for_pd branch November 15, 2019 17:54
@boylee1111 boylee1111 mentioned this pull request Nov 16, 2019
Merged
@msau42 msau42 mentioned this pull request Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jsafrane jsafrane Awaiting requested review from jsafrane

@verult verult Awaiting requested review from verult

Assignees

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

5 participants

@davidz627 @k8s-ci-robot @msau42 @ddebroy @fejta-bot