Skip to content

Moving WindowsRunAsUserName to beta#84882

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
marosset:run-as-username-beta
Nov 12, 2019
Merged

Moving WindowsRunAsUserName to beta#84882
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
marosset:run-as-username-beta

Conversation

@marosset
Copy link
Copy Markdown
Contributor

@marosset marosset commented Nov 6, 2019 •
edited
Loading

What type of PR is this?
/kind api-change
/sig windows

What this PR does / why we need it:
This graduates the WindowsRunAsUserName feature to beta enabling the feature by default.

Special notes for your reviewer:
WindowsRunAsUserName was added with #79489

Does this PR introduce a user-facing change?:

Moving WindowsRunAsUserName feature to beta

yes - doc pr kubernetes/website#17460

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[Enhancement]: kubernetes/enhancements#1043

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2019

Welcome @marosset!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2019

Hi @marosset. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Nov 6, 2019
@marosset marosset force-pushed the run-as-username-beta branch from c1ed74e to 61688e3 Compare November 6, 2019 23:20
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 6, 2019
@PatrickLang
Copy link
Copy Markdown
Contributor

PatrickLang commented Nov 6, 2019

/ok-to-test
/milestone v1.17
/test pull-kubernetes-e2e-aks-engine-azure-windows

cc @adelina-t @BCLAU

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 6, 2019
@PatrickLang PatrickLang mentioned this pull request Nov 6, 2019
Closed
4 tasks
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Nov 7, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 7, 2019

/retest

liggitt
liggitt reviewed Nov 7, 2019
View reviewed changes
liggitt
liggitt reviewed Nov 7, 2019
View reviewed changes
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 7, 2019

This needs a release note. Now that this is enabled by default, are there e2e tests that should drop a [Feature:...] tag so they run in regular e2e test suites?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 7, 2019
@marosset marosset changed the title Graduating WindowsRunAsUserName to beta Moving WindowsRunAsUserName to beta Nov 7, 2019
@marosset
Copy link
Copy Markdown
Contributor Author

marosset commented Nov 7, 2019

E2e test configs are in windows-testing and I'm working on changes to remove the feature flag now. I'll reference the PR here once it is created.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 8, 2019
@marosset marosset mentioned this pull request Nov 8, 2019
Merged
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 8, 2019 •
edited
Loading

@marosset: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure-windows 61688e3342ea897005318ceb98ea45cb7a962012 link /test pull-kubernetes-e2e-aks-engine-azure-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 10, 2019

/approve

thanks, lgtm. please squash down to a single commit for merge.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2019
@liggitt liggitt self-assigned this Nov 10, 2019
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 10, 2019 •
edited
Loading

sig/windows has final lgtm
cc @PatrickLang

@marosset marosset force-pushed the run-as-username-beta branch from 18193e6 to 6d4aea6 Compare November 11, 2019 19:28
@marosset
Copy link
Copy Markdown
Contributor Author

marosset commented Nov 11, 2019

Squashed, thanks @liggitt

@claudiubelu
Copy link
Copy Markdown
Contributor

claudiubelu commented Nov 12, 2019

Looks good to me. Afterwards, we can enable for Windows some of the non-root E2E tests (ofc, with some Windows-specific adaptations)

@PatrickLang
Copy link
Copy Markdown
Contributor

PatrickLang commented Nov 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2019
michmike
michmike approved these changes Nov 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@michmike michmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, marosset, michmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3eff237 into kubernetes:master Nov 12, 2019
@PatrickLang PatrickLang mentioned this pull request Nov 13, 2019
Merged
claudiubelu added a commit to claudiubelu/kubernetes that referenced this pull request Nov 19, 2019
@claudiubelu
tests: Removes [LinuxOnly] tag from a few tests
c80fe4d 
We've added the WindowsRunAsUserName feature some time ago, and it was
promoted to Beta for v1.17. We can now remove the [LinuxOnly] tag for
a few tests.

Depends On: kubernetes#83058
Depends On: kubernetes#84882
@claudiubelu claudiubelu mentioned this pull request Nov 19, 2019
Merged
@marosset marosset mentioned this pull request Dec 2, 2019
Closed
6 tasks
@marosset marosset deleted the run-as-username-beta branch April 10, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@dchen1107 dchen1107 Awaiting requested review from dchen1107

+1 more reviewer

@michmike michmike michmike approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liggitt liggitt

@michmike michmike

@PatrickLang PatrickLang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

API Reviews
Status: API review completed, 1.17

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

7 participants

@marosset @k8s-ci-robot @PatrickLang @fejta-bot @liggitt @claudiubelu @michmike