Skip to content

Promoting EndpointSlices to beta#84390

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
robscott:endpointslice-beta
Nov 14, 2019
Merged

Promoting EndpointSlices to beta#84390
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
robscott:endpointslice-beta

Conversation

@robscott
Copy link
Copy Markdown
Member

@robscott robscott commented Oct 25, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
EndpointSlices provide significant scalability improvements as an alternative to Endpoints. The alpha release has proved itself well through a wide variety of scale testing, including tests up to 50k endpoints in 4k node clusters. Graduating EndpointSlices to beta will ensure that network endpoints are scalable and performant by default in Kubernetes.

Special notes for your reviewer:
The KEP outlines the graduation criteria for a beta release of EndpointSlices in 1.17. Presently all requirements are merged or have PRs ready for final review/approval. I'll keep this updated with the current status of each requirement:

Does this PR introduce a user-facing change?:

EndpointSlices are now beta and enabled by default for better Network Endpoint performance at scale.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig network api-machinery
/priority important-soon
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver area/ipvs area/kubectl area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Oct 26, 2019
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 26, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

This was referenced Oct 30, 2019
Merged
Merged
Merged
Closed
@robscott robscott force-pushed the endpointslice-beta branch 3 times, most recently from a6d8ee0 to 0dc1296 Compare November 9, 2019 01:31
@robscott
Copy link
Copy Markdown
Member Author

robscott commented Nov 9, 2019

/retest

@robscott robscott force-pushed the endpointslice-beta branch 4 times, most recently from da92b2c to 16a0728 Compare November 13, 2019 20:09
@aojea
Copy link
Copy Markdown
Member

aojea commented Nov 13, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from aojea November 13, 2019 21:00
@robscott robscott force-pushed the endpointslice-beta branch 2 times, most recently from 656b7b0 to fa5fa08 Compare November 13, 2019 21:32
@thockin
Copy link
Copy Markdown
Member

thockin commented Nov 13, 2019 via email

thockin
thockin reviewed Nov 13, 2019
View reviewed changes
pkg/proxy/winkernel/proxier_test.go Outdated
Copy link
Copy Markdown
Member

@thockin thockin Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At what stage do we add EPSlice support to Windows proxiers?

Copy link
Copy Markdown
Member Author

@robscott robscott Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully soon, maybe 1.18. I'll try to reach out to some of the people who are more familiar with that side of things to see if we can work together to get EndpointSlice integration in place.

thockin
thockin reviewed Nov 13, 2019
View reviewed changes
@robscott
Copy link
Copy Markdown
Member Author

robscott commented Nov 13, 2019

@thockin I don't think the order matters too much between this and the related proxy PR, I'd say whichever is ready first can go in first and then the other can update based on that. I'm going to be doing the final EndpointSlice + dual stack work on kube-proxy as well, so either way, it'll be me that has to deal with whichever one gets in first.

thockin
thockin reviewed Nov 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 64f4be5 into kubernetes:master Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 14, 2019
liggitt
liggitt reviewed Nov 14, 2019
View reviewed changes
cmd/kube-controller-manager/app/discovery.go
)

func startEndpointSliceController(ctx ControllerContext) (http.Handler, bool, error) {
if !ctx.AvailableResources[discoveryv1alpha1.SchemeGroupVersion.WithResource("endpointslices")] {
Copy link
Copy Markdown
Member

@liggitt liggitt Nov 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to check if the beta API is available... beta APIs can be turned off and components should tolerate that.

Copy link
Copy Markdown
Member

@liggitt liggitt Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and check if the EndpointSlice feature is enabled before running

This was referenced Nov 15, 2019
Closed
Closed
lblackstone added a commit to pulumi/pulumi-kubernetes that referenced this pull request Dec 2, 2019
@lblackstone
Update to v1.17.0-rc.1
52ec62d 
Got it compiling again by removing discovery/v1alpha1 from SDK
See kubernetes/kubernetes#84390
lblackstone added a commit to pulumi/pulumi-kubernetes that referenced this pull request Dec 9, 2019
@lblackstone
Update to v1.17.0-rc.1
dd22eb1 
Got it compiling again by removing discovery/v1alpha1 from SDK
See kubernetes/kubernetes#84390
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#84390 from robscott/endpointslice-beta
c859719 
Promoting EndpointSlices to beta

Kubernetes-commit: 64f4be5
@robscott robscott deleted the endpointslice-beta branch March 11, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@thockin thockin thockin left review comments

@a-robinson a-robinson Awaiting requested review from a-robinson

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@aojea aojea Awaiting requested review from aojea

Assignees

@freehan freehan

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/ipvs area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

7 participants

@robscott @fejta-bot @aojea @thockin @k8s-ci-robot @liggitt @freehan