Skip to content

Upgrade to etcd client 3.3.17#83801

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jpbetz:etcd-3_3_17_client
Oct 12, 2019
Merged

Upgrade to etcd client 3.3.17#83801
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jpbetz:etcd-3_3_17_client

Conversation

@jpbetz
Copy link
Copy Markdown
Contributor

@jpbetz jpbetz commented Oct 11, 2019 •
edited by nikhita
Loading

Upgrade to etcd 3.3.16 that was merged yesterday rolledback because etcd 3.3.16 was a bad release. etcd 3.3.17 is the same as 3.3.16, but with a clean release (#83761).

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes for two major issues with the etcd 3.3 client to 1.16:

  • etcd client does not parse IPv6 addresses correctly when members are joining
  • failover on multi-member etcd cluster fails certificate check on DNS mismatch

Which issue(s) this PR fixes:

Fixes #83550 via etcd-io/etcd#11211 (backported to etcd 3.3 via etcd-io/etcd#11216)
Fixes #83028 via etcd-io/etcd#11184 (backported to etcd 3.3 via etcd-io/etcd#11215)

Special notes for your reviewer:

Separate PR to upgrade to etcd 3.3.17 server will follow. We typically upgrade clients first.

Does this PR introduce a user-facing change?:

Upgrade to etcd client 3.3.17 to fix bug where etcd client does not parse IPv6 addresses correctly when members are joining, and to fix bug where failover on multi-member etcd cluster fails certificate check on DNS mismatch

/sig api-machinery
/area etcd
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/etcd priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2019
@k8s-ci-robot k8s-ci-robot requested review from a team, liggitt and logicalhan October 11, 2019 20:31
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Oct 11, 2019
odinuge
odinuge approved these changes Oct 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

You should probably remove the changelog from the previous PR to avoid duplicates in the changelog, otherwise lgtm. 😄

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@jpbetz jpbetz changed the title Upgrade to etcd 3.3.17 Upgrade to etcd client 3.3.17 Oct 11, 2019
@jpbetz
Copy link
Copy Markdown
Contributor Author

jpbetz commented Oct 11, 2019

You should probably remove the changelog from the previous PR to avoid duplicates in the changelog, otherwise lgtm.

Done, thanks!

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 11, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@jpbetz jpbetz mentioned this pull request Oct 11, 2019
Merged
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 11, 2019

/retest

1 similar comment
@jpbetz
Copy link
Copy Markdown
Contributor Author

jpbetz commented Oct 11, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5e26508 into kubernetes:master Oct 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 12, 2019
@jpbetz jpbetz mentioned this pull request Oct 14, 2019
Closed
@jpbetz jpbetz mentioned this pull request Oct 15, 2019
Merged
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 15, 2019

it looks like this didn't bump bbolt to 1.3.3, even though etcd did between 3.3.15 and 3.3.17. should it have?

@jpbetz jpbetz mentioned this pull request Oct 15, 2019
Merged
@jpbetz
Copy link
Copy Markdown
Contributor Author

jpbetz commented Oct 15, 2019

it looks like this didn't bump bbolt to 1.3.3, even though etcd did between 3.3.15 and 3.3.17. should it have?

Yes. This got missed. I've opened #83970 to bump bbolt.

ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
@k8s-ci-robot @ohsewon
Merge pull request kubernetes#83801 from jpbetz/etcd-3_3_17_client
e54833b 
Upgrade to etcd client 3.3.17
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2019
@k8s-ci-robot
Merge pull request #83968 from jpbetz/rel1.16-etcd-3.3.17
f2b2d8b 
Manual cherry pick of #83801: Upgrade to etcd 3.3.17 client + bbolt v1.3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@logicalhan logicalhan Awaiting requested review from logicalhan

1 more reviewer

@odinuge odinuge odinuge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liggitt liggitt

@odinuge odinuge

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

4 participants

@jpbetz @liggitt @k8s-ci-robot @odinuge