Mark 'wait until preStop hook completes the process' flaky#83792
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Oct 11, 2019
Merged
Mark 'wait until preStop hook completes the process' flaky#83792k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Member
|
/lgtm |
Member
Author
|
/priority critical-urgent |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Review the full test history for this PR. Silence the bot with an |
ohsewon
pushed a commit
to ohsewon/kubernetes
that referenced
this pull request
Oct 16, 2019
Mark 'wait until preStop hook completes the process' flaky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
The error in the prestop test was not getting checked. When a staticcheck fix PR started checking it, the test started flaking badly (xref #83681 (comment)). This marks it flaky so sig-node can investigate/correct the test.
Does this PR introduce a user-facing change?:
/sig node
/cc @BenTheElder @Random-Liu