Update etcd client to 3.3.16#83735
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Oct 10, 2019
Merged
Conversation
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
Member
|
Thanks @jpbetz !! |
nikhita
added a commit
to nikhita/kubernetes
that referenced
this pull request
Oct 11, 2019
etcd was updated to 3.3.16 in kubernetes#83735. After this, an issue was found with the release and the tag was deleted and re-tagged: etcd-io/etcd#11230. Due to this, the hash while downloading (`go mod download`) the tag no longer equalled the old hash in go.sum which led to a checksum mismatch error: ``` verifying github.com/coreos/etcd@v3.3.16+incompatible: checksum mismatch downloaded: h1:2eX1BjV6Wfvl41/35OBA5Np4BHezdTJzhIxSMYxOArA= go.sum: h1:hQaR//OAeI1FQ3G5bGRL9VpFOCurqnEHSup4W693Tb4= ``` This was not caught by CI because the old tag existed at the time of testing the PR (this was, however, caught by the publishing-bot). This commit updates the hash in go.sum to be equal to the new hash that we get after downloading using `go mod download`.
jpbetz
added a commit
to jpbetz/kubernetes
that referenced
this pull request
Oct 11, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 11, 2019
Revert #83735: Update etcd client to 3.3.16
Contributor
|
I see the milestone here is set to version 1.17. Will this be backported to the 1.16 patch release line? |
Member
|
yes |
Contributor
Author
|
Yes and note this PR was rolled back and we are going to upgrade to etcd 3.3.17 and then back port that version to 1.16 |
Contributor
|
Great. Version 1.16.2 can't come soon enough. It looks like that's planned for 15 October 2019. |
Contributor
|
Cherry-pick patch of etcd version 3.3.17 for Kubernetes 1.16: #83915. |
Contributor
Author
ohsewon
pushed a commit
to ohsewon/kubernetes
that referenced
this pull request
Oct 16, 2019
Update etcd client to 3.3.16
ohsewon
pushed a commit
to ohsewon/kubernetes
that referenced
this pull request
Oct 16, 2019
ohsewon
pushed a commit
to ohsewon/kubernetes
that referenced
this pull request
Oct 16, 2019
Revert kubernetes#83735: Update etcd client to 3.3.16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes for two major issues with the etcd 3.3 client to 1.16:
Which issue(s) this PR fixes:
Fixes #83550 via etcd-io/etcd#11211 (backported to etcd 3.3.16 via etcd-io/etcd#11216)
Fixes #83028 via etcd-io/etcd#11184 (backported to etcd 3.3.16 via etcd-io/etcd#11215)
Special notes for your reviewer:
Separate PR to upgrade to etcd 3.3.16 server will follow. We typically upgrade clients first.
Does this PR introduce a user-facing change?:
(release note removed due to rollback)
/sig api-machinery
/area etcd
/priority critical-urgent