Delete duplicate resource.Quantity.Copy()#81627
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Aug 22, 2019
Merged
Delete duplicate resource.Quantity.Copy()#81627k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
mattjmcnaughton
approved these changes
Aug 20, 2019
Contributor
mattjmcnaughton
left a comment
There was a problem hiding this comment.
/lgtm
no concerns from the sig-node perspective. i trust the compiler to check that this was changed in all the proper places.
/test pull-kubernetes-dependencies
Contributor
|
/assign @deads2k @derekwaynecarr @erictune |
thockin
reviewed
Aug 20, 2019
Member
thockin
left a comment
There was a problem hiding this comment.
I had to read the body of Copy() and DeepCopy() but I am convinced it is equivalent.
Thanks!
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tallclair, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
Delete duplicate resource.Quantity.Copy() Kubernetes-commit: 6b47754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Quantity.Copy()andQuantity.DeepCopy()do the same thing. The only different is thatCopy()returns a pointer, whileDeepCopy()does not. In most cases,DeepCopy()is what is actually needed (even though Copy is more common), so I kept that one.Does this PR introduce a user-facing change?:
/sig apimachinery
/assign @thockin