Skip to content

Check node status as part of validate-cluster.sh.#7932

Merged
roberthbailey merged 1 commit intokubernetes:masterfrom
fabioy:check-good-nodes.fix
May 8, 2015
Merged

Check node status as part of validate-cluster.sh.#7932
roberthbailey merged 1 commit intokubernetes:masterfrom
fabioy:check-good-nodes.fix

Conversation

@fabioy
Copy link
Copy Markdown
Contributor

@fabioy fabioy commented May 7, 2015

This should fix issue #7920. Checked the script on both Linux and Mac OS X (Yosemite).

@fabioy
Copy link
Copy Markdown
Contributor Author

fabioy commented May 7, 2015

cc @roberthbailey

@roberthbailey roberthbailey self-assigned this May 7, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/good/ready

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed.

@fabioy fabioy force-pushed the check-good-nodes.fix branch from 49815d9 to 89b3ffa Compare May 7, 2015 23:13
@roberthbailey
Copy link
Copy Markdown
Contributor

LGTM.

@roberthbailey
Copy link
Copy Markdown
Contributor

No reason to wait for travis/shippable because this is just changing a shell script. It'll be tested by jenkins e2e.

roberthbailey added a commit that referenced this pull request May 8, 2015
Check node status as part of validate-cluster.sh.
@roberthbailey roberthbailey merged commit c903aa7 into kubernetes:master May 8, 2015
@fabioy fabioy deleted the check-good-nodes.fix branch February 26, 2016 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants